Skip to content

Commit 67f1825

Browse files
committed
docs(metadata-fs): re-anchor the dead tracker citations to the commit that decided them
Three comment and docblock sites in packages/metadata-fs cited a tracker number that now answers 404 (two census sites, in src/repository.ts and src/sync.ts, and one test comment in test/close-terminates-watch.test.ts). Each now cites commit 7d81c88, the change that made close() terminate watch iterators instead of emitting a drain event, measured why the drain event was the wrong shape, and wrote invariant 8 in metadata-core. The live #11127 beside one of them stays. Comment text only; no line count changes. Claude-Session: https://claude.ai/code/session_017ErfyP2Rx7XWHJA27QjyUi Co-authored-by: Claude <noreply@anthropic.com>
1 parent 0fc8087 commit 67f1825

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/metadata-fs/src/repository.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ export class FileSystemRepository implements MetadataRepository {
227227
* `terminate()`, which is the same routine the consumer's own
228228
* `iterator.return()` runs, so no consumer has to tell "the repository shut
229229
* down under me" apart from "I broke my own loop". A synthetic drain event
230-
* would be the wrong shape and was measured to be so (#11021): the
230+
* would be the wrong shape and was measured to be so (commit 7d81c889f): the
231231
* subscriptions most in need of draining are exactly the ones whose filter
232232
* or numeric `since` drops it, and delivering an event has never ended an
233233
* iterator.

‎packages/metadata-fs/src/sync.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class KeyedMutex {
3838
* of event sinks can only express shutdown as "send an event", and an event is
3939
* precisely what a filtered or numeric-`since` subscriber is entitled to drop
4040
* — and delivering one has never ended an iterator anyway. See invariant 8 in
41-
* `@objectstack/metadata-core`'s `repository.ts` (#11021, #11127).
41+
* `@objectstack/metadata-core`'s `repository.ts` (commit 7d81c889f, #11127).
4242
*/
4343
export interface BrokerSubscriber {
4444
filter: WatchFilter;

‎packages/metadata-fs/test/close-terminates-watch.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ describe('FileSystemRepository — close() terminates every live watcher (#11127
100100
['filtered + numeric `since`', { org: 'system' } as WatchFilter, true],
101101
// The row that proves the filter half bites on its own.
102102
['filtered, no `since` at all', { org: 'system' } as WatchFilter, false],
103-
// Not filter-dependent here, unlike the sibling defect in #11021: there is
103+
// Not filter-dependent here, unlike the sibling defect commit 7d81c889f fixed: there is
104104
// no drain attempt at all, so the empty filter hangs identically.
105105
['empty filter, no `since`', {} as WatchFilter, false],
106106
['ref-exact filter, no `since`', { org: 'system', type: 'view', name: 'sample_view' } as WatchFilter, false],

0 commit comments

Comments
 (0)