fix(test): reconstruct the v16 baseline via engine-owned, not the retired literal (#3355)

The equivalence pins built their v16 side by passing `managedBy: 'system'` to
`resolveCrudAffordances` — but v17 deletes that row from
`CRUD_AFFORDANCE_DEFAULTS`, so the lookup fell through to the `platform` default
and reconstructed a baseline with `import: true`. The pins caught it (that is
what they are for): the `expect(v16).toEqual(V16_EXPECTED)` guard failed rather
than the comparison silently passing against a wrong baseline.

ADR-0103 D5 gave `engine-owned` the byte-identical locked row `system` carried in
v16, so it is an exact stand-in, and the V16_EXPECTED assertion keeps it honest.
Also adds the NodeNext `.js` extensions the new test files needed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5

Author: claude

packages/platform-objects/src/identity/sys-user-preference.managed-by.test.ts

@@ -16,12 +16,19 @@
 
 import { describe, expect, it } from 'vitest';
 import { resolveCrudAffordances } from '@objectstack/spec/data';
-import { SysUserPreference } from './sys-user-preference.object';
+import { SysUserPreference } from './sys-user-preference.object.js';
 
 const V16_EXPECTED = { create: true, import: false, edit: true, delete: true, exportCsv: true };
 const V17_EXPECTED = { create: true, import: true, edit: true, delete: true, exportCsv: true };
 
-const asV16 = { managedBy: 'system', userActions: { create: true, edit: true, delete: true } };
+/**
+ * The v16 shape, reconstructed via `engine-owned` — which ADR-0103 D5 gave the
+ * byte-identical locked default row `system` carried in v16. The retired literal
+ * cannot be used: v17 deleted its row from `CRUD_AFFORDANCE_DEFAULTS`, so it would
+ * fall through to the `platform` default and reconstruct the wrong baseline. The
+ * `toEqual(V16_EXPECTED)` assertion below keeps the stand-in honest.
+ */
+const asV16 = { managedBy: 'engine-owned', userActions: { create: true, edit: true, delete: true } };
 
 describe('#3355 — sys_user_preference moves to `system-data` with its affordances intact', () => {
   it('declares the new bucket and no longer carries a redundant `userActions` block', () => {

packages/plugins/plugin-approvals/src/sys-approval-delegation.object.test.ts

@@ -27,7 +27,14 @@ import { SysApprovalDelegation } from './sys-approval-delegation.object';
 describe('#3355 — sys_approval_delegation moves to `system-data` with its affordances intact', () => {
   const V16_EXPECTED = { create: true, import: false, edit: true, delete: true, exportCsv: true };
   const V17_EXPECTED = { create: true, import: true, edit: true, delete: true, exportCsv: true };
-  const asV16 = { managedBy: 'system', userActions: { create: true, edit: true, delete: true } };
+  /**
+   * The v16 shape, reconstructed via `engine-owned` — which ADR-0103 D5 gave the
+   * byte-identical locked default row `system` carried in v16. The retired
+   * literal cannot be used: v17 deleted its row from `CRUD_AFFORDANCE_DEFAULTS`,
+   * so it would fall through to the `platform` default and reconstruct the wrong
+   * baseline. The `toEqual(V16_EXPECTED)` assertion below keeps it honest.
+   */
+  const asV16 = { managedBy: 'engine-owned', userActions: { create: true, edit: true, delete: true } };
 
   it('declares the new bucket and no longer carries a redundant `userActions` block', () => {
     expect(SysApprovalDelegation.managedBy).toBe('system-data');

packages/plugins/plugin-security/src/objects/managed-by-system-data.test.ts

@@ -26,19 +26,31 @@
 
 import { describe, expect, it } from 'vitest';
 import { resolveCrudAffordances } from '@objectstack/spec/data';
-import { SysUserPosition } from './sys-user-position.object';
-import { SysUserPermissionSet } from './sys-user-permission-set.object';
-import { SysPositionPermissionSet } from './sys-position-permission-set.object';
+import { SysUserPosition } from './sys-user-position.object.js';
+import { SysUserPermissionSet } from './sys-user-permission-set.object.js';
+import { SysPositionPermissionSet } from './sys-position-permission-set.object.js';
 
 /** What each object resolved to in v16: LOCKED `system` + `userActions: {c,e,d}`. */
 const V16_EXPECTED = { create: true, import: false, edit: true, delete: true, exportCsv: true };
 
 /** What each object resolves to in v17: the `system-data` default, no `userActions`. */
 const V17_EXPECTED = { create: true, import: true, edit: true, delete: true, exportCsv: true };
 
-/** The v16 declaration shape, reconstructed so the equivalence is computed, not asserted twice. */
+/**
+ * The v16 declaration shape, reconstructed so the equivalence is COMPUTED rather
+ * than asserted twice.
+ *
+ * It is spelled `engine-owned`, not `system`, on purpose: v17 deleted the `system`
+ * row from `CRUD_AFFORDANCE_DEFAULTS`, so passing the retired literal would fall
+ * through to the `platform` default and quietly reconstruct the wrong baseline
+ * (that mistake is what this comment exists to prevent — it read green-ish and was
+ * wrong). ADR-0103 D5 gave `engine-owned` the byte-identical locked row `system`
+ * carried in v16 — `{create,import,edit,delete: false, exportCsv: true}` — so it is
+ * an exact stand-in for the old bucket default. `expect(v16).toEqual(V16_EXPECTED)`
+ * below is the check that this stand-in stayed honest.
+ */
 const asV16 = (obj: { userActions?: unknown }) => ({
-  managedBy: 'system',
+  managedBy: 'engine-owned',
   userActions: obj.userActions ?? { create: true, edit: true, delete: true },
 });
 

packages/services/service-messaging/src/objects/managed-by-system-data.test.ts

@@ -15,15 +15,28 @@
 
 import { describe, expect, it } from 'vitest';
 import { resolveCrudAffordances } from '@objectstack/spec/data';
-import { NotificationTemplate } from './notification-template.object';
-import { NotificationSubscription } from './notification-subscription.object';
-import { NotificationPreference } from './notification-preference.object';
+import { NotificationTemplate } from './notification-template.object.js';
+import { NotificationSubscription } from './notification-subscription.object.js';
+import { NotificationPreference } from './notification-preference.object.js';
 
 const V16_EXPECTED = { create: true, import: false, edit: true, delete: true, exportCsv: true };
 const V17_EXPECTED = { create: true, import: true, edit: true, delete: true, exportCsv: true };
 
+/**
+ * The v16 declaration shape, reconstructed so the equivalence is COMPUTED rather
+ * than asserted twice.
+ *
+ * It is spelled `engine-owned`, not `system`, on purpose: v17 deleted the `system`
+ * row from `CRUD_AFFORDANCE_DEFAULTS`, so passing the retired literal would fall
+ * through to the `platform` default and quietly reconstruct the wrong baseline
+ * (that mistake is what this comment exists to prevent — it read green-ish and was
+ * wrong). ADR-0103 D5 gave `engine-owned` the byte-identical locked row `system`
+ * carried in v16 — `{create,import,edit,delete: false, exportCsv: true}` — so it is
+ * an exact stand-in for the old bucket default. `expect(v16).toEqual(V16_EXPECTED)`
+ * below is the check that this stand-in stayed honest.
+ */
 const asV16 = (obj: { userActions?: unknown }) => ({
-  managedBy: 'system',
+  managedBy: 'engine-owned',
   userActions: obj.userActions ?? { create: true, edit: true, delete: true },
 });