Repository navigation
Commit 5ca8d05
committed
fix(metadata-protocol): type the test helper's
CI's TypeScript Type Check went red on my push: the metadata-protocol DEBT
entry records 63 raw tsc errors and `tsc --noEmit` reported 64. The +1 was mine
and real:
sys-metadata-repository.package-writability.test.ts(166,21): error TS2322:
Type 'string' is not assignable to type '"object" | "view" | ... |
"email_template"'.
`putWith`'s `opts.type` was `string`; `MetaRef['type']` is a literal union. The
suite ran green under vitest either way — this package has no `typecheck`
script, so its type surface is only judged by the ledger in CI, which is
exactly the gap that let a widened parameter through a local run.
Fixed at the source, not in the ledger: DEBT is a ratchet that may only shrink,
and raising an entry for a file added in the same PR would be the worst version
of that. `tsc --noEmit` now reports 63 for the package, matching the recorded
entry, with zero errors attributable to either file this PR touches.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AmES43BMDg4bPrxTdi5q7ttype as MetaRef['type'] (#7682)1 parent 1bccc1d commit 5ca8d05
1 file changed
Lines changed: 15 additions & 2 deletions
Lines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
159 | | - | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
160 | 168 | | |
161 | 169 | | |
162 | | - | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
163 | 176 | | |
164 | 177 | | |
165 | 178 | | |
| |||
0 commit comments