Skip to content

Commit 5c3307b

Browse files
baozhoutaoclaude
andcommitted
docs(rest): the outage comment says what was measured, not what it assumed
The comment promised a 5xx. Measured, that failure arrives as 400 — an unrecognised error lands on `mapDataError`'s terminal fallback, which is a pre-existing classification on every error this route reports. The propagation is the fact worth stating; the status is someone else's bug and is filed as one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016FNvXhtSdnEGEfLEsMmvxh
1 parent 5cbcfc4 commit 5c3307b

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

‎packages/rest/src/rest-server.ts‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3579,9 +3579,17 @@ export class RestServer {
35793579
} else {
35803580
// A `matchEndpoint` throw propagates: its
35813581
// contract distinguishes an unreadable store
3582-
// from a miss, and this route answers 5xx
3583-
// (via handleRouteError) rather than claiming
3584-
// the deployment declares nothing.
3582+
// from a miss, so this route FAILS (through
3583+
// `handleRouteError`) rather than claiming
3584+
// the deployment declares nothing. Measured:
3585+
// that failure is currently reported as 400,
3586+
// because an unrecognised error lands on
3587+
// `mapDataError`'s terminal fallback — a
3588+
// pre-existing classification on every error
3589+
// this route reports, not something this
3590+
// narrowing chose. Filed separately; do not
3591+
// read the propagation here as a promise
3592+
// about which status arrives.
35853593
const servedList = await selectServedEndpoints(list, authority, {
35863594
error: (message: string, meta?: unknown) =>
35873595
meta === undefined ? logError(message) : logError(message, meta),

0 commit comments

Comments
 (0)