fix(seed): complete Dataset->Seed rename + load published seed rows (locally verified) (#1620)

* fix(runtime): seed-apply read-back reads body from wrapper .item field

The diagnostic added in the prior fix revealed the exact shape: a direct
protocol.getMetaItem() call returns a WRAPPER `{ type, name, item, lock,
editable, deletable, resettable }` — the seed body (object/records) is under
`.item`, not top-level and not `.metadata`/`.body` (the HTTP endpoint unwraps
it, which is why a manual GET showed the body directly and misled the first
guess). Add `.item` to the extraction chain so the published seed body is
actually read → its rows load on publish.

This completes the magic-moment loop: AI builds → publishes → sample seed rows
load into the object.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(seed): complete Dataset->Seed rename + load published seed rows

Locally verified together (106 spec + 163 runtime tests green) BEFORE deploying.
Prior split attempts failed because the rename never landed on main (auto-merge
raced ahead of the rename commit) and the seed-apply hook was patched blind
through the slow deploy loop.

1. Finish the lost Dataset->Seed rename:
   - data/dataset.zod.ts -> data/seed.zod.ts (+ dataset.test.ts -> seed.test.ts)
   - DatasetSchema->SeedSchema (canonical), Dataset->Seed, DatasetInput->SeedInput,
     DatasetMode->SeedMode, DatasetImportMode->SeedImportMode,
     DatasetLoadResult(Schema)->SeedLoadResult(Schema), defineDataset->defineSeed
   - SeedLoaderRequest field datasets->seeds (+ all constructors/readers/tests)
   - callers: 3 examples, plugin-org-scoping, runtime seed-loader + app-plugin,
     spec stack/manifest/package-artifact/metadata-collection/solution-blueprint
   Frees the dataset name for the ADR-0021 analytics layer. NOT renamed (other
   concepts): env-artifact datasets bucket, seed-datasets service key, manifest
   data, RAGFlow datasets.

2. Fix publish-drafts seed-apply so published seed rows actually load:
   protocol.getMetaItem (direct) returns a WRAPPER {type,name,item,...} - the
   seed body is under .item (the HTTP endpoint unwraps it, which misled earlier
   guesses). Read .item; try active-org then env-wide; never report success while
   loading 0 rows. New integration test (http-dispatcher.test.ts) exercises the
   real SeedLoaderService end-to-end and pins this.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

examples/app-crm/src/data/index.ts

@@ -1,14 +1,14 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
-import { defineDataset } from '@objectstack/spec/data';
+import { defineSeed } from '@objectstack/spec/data';
 import { cel } from '@objectstack/spec';
 import { Account } from '../objects/account.object.js';
 import { Contact } from '../objects/contact.object.js';
 import { Opportunity } from '../objects/opportunity.object.js';
 import { Lead } from '../objects/lead.object.js';
 import { Activity } from '../objects/activity.object.js';
 
-const accounts = defineDataset(Account, {
+const accounts = defineSeed(Account, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -18,7 +18,7 @@ const accounts = defineDataset(Account, {
   ],
 });
 
-const contacts = defineDataset(Contact, {
+const contacts = defineSeed(Contact, {
   mode: 'upsert',
   externalId: 'email',
   records: [
@@ -28,7 +28,7 @@ const contacts = defineDataset(Contact, {
   ],
 });
 
-const opportunities = defineDataset(Opportunity, {
+const opportunities = defineSeed(Opportunity, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -56,7 +56,7 @@ const opportunities = defineDataset(Opportunity, {
   ],
 });
 
-const leads = defineDataset(Lead, {
+const leads = defineSeed(Lead, {
   mode: 'upsert',
   externalId: 'email',
   records: [
@@ -101,7 +101,7 @@ const leads = defineDataset(Lead, {
   ],
 });
 
-const activities = defineDataset(Activity, {
+const activities = defineSeed(Activity, {
   mode: 'upsert',
   externalId: 'subject',
   records: [

examples/app-showcase/src/data/index.ts

@@ -1,6 +1,6 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
-import { defineDataset } from '@objectstack/spec/data';
+import { defineSeed } from '@objectstack/spec/data';
 import { cel } from '@objectstack/spec';
 import { Account } from '../objects/account.object.js';
 import { Project } from '../objects/project.object.js';
@@ -14,7 +14,7 @@ import { Team, ProjectMembership } from '../objects/team.object.js';
  * work location (map), and projects span every status and health.
  */
 
-const accounts = defineDataset(Account, {
+const accounts = defineSeed(Account, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -27,7 +27,7 @@ const accounts = defineDataset(Account, {
   ],
 });
 
-const projects = defineDataset(Project, {
+const projects = defineSeed(Project, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -40,7 +40,7 @@ const projects = defineDataset(Project, {
 });
 
 // Tasks across all five board columns, with dates + locations to drive every view.
-const tasks = defineDataset(Task, {
+const tasks = defineSeed(Task, {
   mode: 'upsert',
   externalId: 'title',
   records: [
@@ -57,7 +57,7 @@ const tasks = defineDataset(Task, {
   ],
 });
 
-const categories = defineDataset(Category, {
+const categories = defineSeed(Category, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -68,7 +68,7 @@ const categories = defineDataset(Category, {
   ],
 });
 
-const teams = defineDataset(Team, {
+const teams = defineSeed(Team, {
   mode: 'upsert',
   externalId: 'name',
   records: [
@@ -77,7 +77,7 @@ const teams = defineDataset(Team, {
   ],
 });
 
-const memberships = defineDataset(ProjectMembership, {
+const memberships = defineSeed(ProjectMembership, {
   mode: 'insert',
   records: [
     { team: 'Experience', project: 'Website Relaunch', role: 'owner', allocation_percent: 80 },

examples/app-todo/src/data/index.ts

@@ -1,10 +1,10 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
-import { defineDataset } from '@objectstack/spec/data';
+import { defineSeed } from '@objectstack/spec/data';
 import { cel } from '@objectstack/spec';
 import { Task } from '../objects/task.object';
 
-const tasks = defineDataset(Task, {
+const tasks = defineSeed(Task, {
   mode: 'upsert',
   externalId: 'subject',
   records: [

packages/formula/src/seed-eval.ts

@@ -1,7 +1,7 @@
 /**
  * Seed-value resolver.
  *
- * `Dataset.records` accepts {@link SeedValue} = primitive | Expression | array
+ * `Seed.records` accepts {@link SeedValue} = primitive | Expression | array
  * | object — install-time resolution walks the tree and replaces any
  * Expression node with its evaluated result. This is what makes
  * `close_date: cel\`now() + duration("P30D")\`` resolve to *the customer's*

packages/plugins/plugin-org-scoping/src/claim-orphan-org-rows.ts

@@ -3,7 +3,7 @@
 /**
  * claimOrphanOrgRows — assign seed-loaded records to the first organization.
  *
- * Seeds (`defineDataset`) are inserted by `SeedLoaderService` using
+ * Seeds (`defineSeed`) are inserted by `SeedLoaderService` using
  * `{ context: { isSystem: true } }`, which intentionally bypasses
  * SecurityPlugin's `organization_id` auto-fill. As a result, in
  * multi-tenant mode every seed row lands with `organization_id = NULL`.

packages/runtime/src/app-plugin.ts

@@ -520,7 +520,7 @@ export class AppPlugin implements Plugin {
                      const seedLoader = new SeedLoaderService(ql, md, loggerRef);
                      const { SeedLoaderRequestSchema } = await import('@objectstack/spec/data');
                      const request = SeedLoaderRequestSchema.parse({
-                         datasets: datasetsNow,
+                         seeds: datasetsNow,
                          config: {
                              defaultMode: 'upsert',
                              multiPass: true,
@@ -540,7 +540,7 @@ export class AppPlugin implements Plugin {
                      };
                  };
                  registerSvc('seed-replayer', replayer);
-                 ctx.logger.info(`[Seeder] Registered ${normalizedDatasets.length} datasets + replayer on kernel (total datasets: ${merged.length})`);
+                 ctx.logger.info(`[Seeder] Registered ${normalizedDatasets.length} datasets + replayer on kernel (total seeds: ${merged.length})`);
              } catch (e: any) {
                  ctx.logger.warn('[Seeder] Failed to register seed-datasets/seed-replayer service', { error: e?.message });
              }
@@ -571,7 +571,7 @@ export class AppPlugin implements Plugin {
                       const seedLoader = new SeedLoaderService(ql, metadata, ctx.logger);
                       const { SeedLoaderRequestSchema } = await import('@objectstack/spec/data');
                       const request = SeedLoaderRequestSchema.parse({
-                          datasets: normalizedDatasets,
+                          seeds: normalizedDatasets,
                           config: { defaultMode: 'upsert', multiPass: true, identity: seedIdentity },
                       });
                       const result = await seedLoader.load(request);

packages/runtime/src/http-dispatcher.test.ts

@@ -982,6 +982,46 @@ describe('HttpDispatcher', () => {
             expect(result.handled).toBe(true);
             expect(result.response?.status).toBe(501);
         });
+
+        // Integration: publishing a `seed` draft must LOAD its rows. This
+        // exercises applyPublishedSeeds end-to-end against the REAL
+        // SeedLoaderService (only the engine/metadata are mocked), so it pins
+        // the read-back shape (protocol.getMetaItem returns a WRAPPER whose body
+        // is under `.item`), the renamed `seeds` request field, and the loader
+        // invocation — the exact chain that silently loaded 0 rows on staging.
+        it('POST /packages/:id/publish-drafts applies published `seed` rows', async () => {
+            const records = [
+                { name: 'Apollo', status: 'active', budget_amount: 120000 },
+                { name: 'Gemini', status: 'planned', budget_amount: 45000 },
+            ];
+            const publishPackageDrafts = vi.fn().mockResolvedValue({
+                success: true, publishedCount: 1, failedCount: 0,
+                published: [{ type: 'seed', name: 'project_seed', version: 'h' }], failed: [],
+            });
+            // protocol.getMetaItem returns the WRAPPER shape (body under `.item`).
+            const getMetaItem = vi.fn().mockResolvedValue({
+                type: 'seed', name: 'project_seed', lock: null, editable: true,
+                item: { object: 'project', externalId: 'name', mode: 'upsert', records },
+            });
+            const insert = vi.fn().mockImplementation(async (_obj: string, rec: any) => ({ id: `id_${rec.name}` }));
+            const find = vi.fn().mockResolvedValue([]); // no existing rows → all insert
+            (kernel as any).getService = vi.fn().mockImplementation((name: string) => {
+                if (name === 'protocol') return Promise.resolve({ publishPackageDrafts, getMetaItem });
+                if (name === 'objectql') return Promise.resolve({ insert, find, update: vi.fn(), registry: { getAllPackages: vi.fn().mockReturnValue([]) } });
+                if (name === 'metadata') return Promise.resolve({ getObject: vi.fn().mockResolvedValue({ name: 'project', fields: { name: { type: 'text' }, status: { type: 'select' }, budget_amount: { type: 'currency' } } }) });
+                return null;
+            });
+
+            const result = await dispatcher.handlePackages('/com.workspace/publish-drafts', 'POST', {}, {}, { request: {} });
+
+            expect(result.response?.status).toBe(200);
+            const seedApplied = (result.response as any)?.body?.data?.seedApplied;
+            expect(seedApplied?.success).toBe(true);
+            expect(seedApplied?.inserted).toBe(2);
+            // rows actually went to the engine
+            expect(insert).toHaveBeenCalledTimes(2);
+            expect(insert).toHaveBeenCalledWith('project', expect.objectContaining({ name: 'Apollo' }), expect.anything());
+        });
     });
 
     // ═══════════════════════════════════════════════════════════════

packages/runtime/src/http-dispatcher.ts

@@ -1775,10 +1775,14 @@ export class HttpDispatcher {
                     readErrors.push(`read ${name}: ${(e as Error)?.message ?? String(e)}`);
                 }
             }
-            // getMetaItem returns the item body directly; tolerate a wrapper.
+            // protocol.getMetaItem (called directly, unlike the HTTP endpoint
+            // which unwraps) returns a WRAPPER: `{ type, name, item, lock,
+            // editable, … }` — the seed body (object/records) lives under
+            // `.item`. Tolerate the wrapper (`.item`) plus the body-direct and
+            // `.metadata`/`.body` shapes other protocols may return.
             const seed = item?.object && Array.isArray(item?.records)
                 ? item
-                : (item?.metadata ?? item?.body);
+                : (item?.item ?? item?.metadata ?? item?.body);
             if (seed?.object && Array.isArray(seed?.records)) {
                 datasets.push(seed);
             } else {
@@ -1795,9 +1799,6 @@ export class HttpDispatcher {
         const { SeedLoaderRequestSchema } = await import('@objectstack/spec/data');
         const loader = new SeedLoaderService(ql, metadata, (this as any).logger ?? console);
         const request = SeedLoaderRequestSchema.parse({
-            // ADR field is `seeds` (renamed from `datasets`); this constructor
-            // was added in the same PR and the rename missed it — passing
-            // `datasets` left `seeds` undefined and the loader saw nothing.
             seeds: datasets,
             config: {
                 defaultMode: 'upsert',