Repository navigation
Commit 48cca4a
Part of #15204
Clause-②: no
**B2, objectstack half (objectui#7611 names it).** Setup's user page
grants a position or a permission set by picking its NAME from the
security catalog, instead of an `add` picker that listed `sys_position`
/ `sys_permission_set` rows (ADR-0131 D3/D4). This PR is one of the pair
that gates #22900 (the boot stops writing `sys_permission_set` rows):
once #22900 lands, a fresh database holds no such row, and the old
pickers would offer nothing.
## What changes
| Surface | Before | Now |
|:--|:--|:--|
| `sys-user.page.ts` Positions / Permission Sets lists | "Assign
position" / "Grant permission set" `add` pickers over `sys_position` /
`sys_permission_set` rows, beside **New** | the two `add` blocks are
deleted. **New** opens the grant form. Remove is the host's row delete
(`RelatedRecordActionsBridge`), unchanged. The Business Units list keeps
its `add` |
| `sys_user_position.position` | a text input (type `text`) | `widget:
'position-ref'`: the form lists `GET /api/v1/meta/position` and stores
the chosen name |
| `sys_user_permission_set.permission_set` | a text input | `widget:
'permission-ref'`: the form lists `GET /api/v1/meta/permission` and
stores the chosen name |
| `sys_user_permission_set.permission_set_id` ("Permission Set (legacy
id)") | an editable lookup on the grant form, though it grants nothing |
`hidden: true`, so it is off the create and edit forms (maintainer,
2026-10-12, 「legacy id 字段隐藏,同意」). The column stays until ADR-0131 C7b
drops its data |
**Until the console pin moves, the two fields render as text inputs**
(the type renderer: a text box for the name). `position-ref` /
`permission-ref` ship in objectui#12175 (PR-5, merged as
`088e0f705520`), and this repo's `.objectui-sha` still pins
`4997995022f8`. An unregistered widget falls back to the `text`
renderer, so nothing breaks. **The pin follows #22874:** `.objectui-sha`
is that PR's single-writer path, and objectui from `e5311165` on reads
`allowEnvironmentOverlay` only, which `main`'s server sends once #22874
lands. A follow-up PR then moves the pin to `088e0f705` (or later),
re-measuring only that hop. `main` is unreleased, so no released build
shows the gap.
This branch briefly carried that pin move (`e486abb9c`), reverted by
`7de0f00c9`. The net diff is phase 2 only: 9 files, tree-identical to
`d4c22c8fe`.
## Measured before the build (phase 1, #15204 6116275825)
On a booted showcase, as the admin:
- both grant lists already offered **New**;
- with the two `add` blocks deleted, every row still offers **Delete**,
and a delete was exercised end to end (UI 4 → 3 rows; the API shows the
row gone).
The renderer's `onRowDelete` prefers the host's `onDelete`; the
`add`-based remove is only its fallback when no host bridge is mounted.
## Pins
- `packages/qa/dogfood/test/grant-name-pickers.dogfood.test.ts` reads
the SERVED `GET /meta/object/<name>` on a booted showcase:
- `position` carries `position-ref`;
- `permission_set` carries `permission-ref`;
- `permission_set_id` is `hidden`, with `permission_set` not hidden as
the control.
- Ablation: stripping the two hints and `hidden` from the objects, then
rebuilding, turned all 3 cases red (`expected undefined to be
'position-ref'`, …); restoring turned them green.
- `sys-user-permission-set-window-columns.test.ts` asserts that neither
grant list carries `add`, with the Business Units list's `add` as the
control. Ablation: re-adding an `add` to the Permission Sets list turned
that case red.
- `format.server-ready-dev-admin-audience.test.ts`: the CLI banner's
"grant it a permission set" pin is re-anchored on the Permission Sets
list (its New), since the "Grant permission set" label is gone.
- `platform-page-i18n-parity.test.ts`: the anti-vacuity floor of inline
locale maps is 44 (was 45), because the two `add` labels went with their
blocks.
## Browser check against the widget (objectui#12175 head `8237a1cd886d`,
built locally before it merged; the merge `088e0f705520` carries the
same widget files)
- The **Position** and **Permission Set** fields render as registry
comboboxes (`registry-ref-position` / `registry-ref-permission`),
listing 16 positions and 17 permission sets.
- Picking `auditor` and `mcp_agent_data_read`, then pressing Create,
wrote both grant rows (verified through the data API).
- "Permission Set (legacy id)" is gone from the form, and both list
headers show only **New**.
## Verification (local, at this head)
- dogfood in full: 253 files passed, 1 skipped; 2,039 tests passed;
- plugin-security: 197 files, 4,045 passed;
- platform-objects: 69 files, 1,086 passed;
- cli unit tier: 282 files, all passed after the floor fix
(`platform-page-i18n-parity` 27/27);
- typecheck green: platform-objects, plugin-security, cli, dogfood;
- `dispatch-gates --ran`: 72 derived families, all recorded with exit 0.
## Changeset
`@objectstack/platform-objects` and `@objectstack/plugin-security`
**patch**, `Clause-②: no`. This changes shipped metadata only; no key
anyone authors moves.
## Acceptance notes
- **objectui finding (carrier: none yet; the seat routes it):** the
`position-ref` picker lists the `everyone` audience anchor among
positions, and the server refuses it as a grant target. Not filtered
here.
- Tier: no governed surface. #22900 waits for this PR and for the pin PR
that follows #22874.
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_013XKtmoR5QCUSTMjiQ3os49
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 4806b18 commit 48cca4a
9 files changed
Lines changed: 133 additions & 52 deletions
File tree
- .changeset
- packages
- cli
- src/utils
- test
- platform-objects/src/pages
- plugins/plugin-security/src/objects
- qa/dogfood/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| 177 | + | |
| 178 | + | |
177 | 179 | | |
178 | | - | |
179 | | - | |
| 180 | + | |
| 181 | + | |
180 | 182 | | |
181 | | - | |
| 183 | + | |
182 | 184 | | |
183 | 185 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1136 | 1136 | | |
1137 | 1137 | | |
1138 | 1138 | | |
1139 | | - | |
| 1139 | + | |
1140 | 1140 | | |
1141 | 1141 | | |
1142 | 1142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
841 | | - | |
842 | | - | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
843 | 844 | | |
844 | 845 | | |
845 | 846 | | |
| |||
Lines changed: 25 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | 52 | | |
55 | 53 | | |
56 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
197 | 200 | | |
198 | 201 | | |
199 | 202 | | |
| |||
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | 209 | | |
221 | 210 | | |
222 | 211 | | |
223 | 212 | | |
224 | 213 | | |
225 | 214 | | |
226 | 215 | | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
235 | 224 | | |
236 | 225 | | |
237 | 226 | | |
238 | 227 | | |
239 | 228 | | |
240 | | - | |
241 | | - | |
| 229 | + | |
242 | 230 | | |
243 | 231 | | |
244 | 232 | | |
| |||
253 | 241 | | |
254 | 242 | | |
255 | 243 | | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | 244 | | |
271 | 245 | | |
272 | 246 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
| |||
100 | 104 | | |
101 | 105 | | |
102 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
103 | 111 | | |
104 | 112 | | |
105 | 113 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
88 | 92 | | |
89 | 93 | | |
90 | 94 | | |
| |||
Lines changed: 59 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
0 commit comments