Skip to content

Commit 3866536

Browse files
committed
docs(cloud-connection): explain why RuntimeConfigPlugin keeps '' unlike its neighbor
The corrected example now has two spellings of "no cloud" two lines apart with no stated reason: MarketplaceInstallLocalPlugin needs the explicit 'off' sentinel, RuntimeConfigPlugin keeps ''. Unexplained, a reader could "normalise" either direction -- including changing install-local back to '', which reproduces the exact defect this card exists to remove. Add a one-line comment: RuntimeConfigPlugin does not re-resolve controlPlaneUrl through resolveCloudUrl(), so '' means "stay on this origin" here rather than "unset" -- the asymmetry is deliberate, not a leftover copy-trap. Part of #8355 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P7vaLs7bhBPi9m3JyzkhDj
1 parent 45c3738 commit 3866536

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎packages/cloud-connection/README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ const plugins = [
4343
// NOT cloud-gated: features.marketplace is derived from what is actually
4444
// mounted, not from this constructor call, so a cloud-less runtime reports
4545
// marketplace: false on its own — there is nothing here to keep in sync.
46+
// `''` here, unlike its neighbor above, is correct as-is: this plugin does
47+
// NOT re-resolve controlPlaneUrl through resolveCloudUrl(), so '' means
48+
// "stay on this origin" rather than "unset" — do not "fix" it to 'off'.
4649
new RuntimeConfigPlugin({ controlPlaneUrl: '', singleEnvironment: true, installLocal: true }),
4750
];
4851
```

0 commit comments

Comments
 (0)