Repository navigation
Commit 2742e53
fix(spec): step 18's rationale gains the form-view-subform-columns-closed fragment (#21090)
Part of #20901
Clause-②: no
One `STEP18_RATIONALE` fragment in
`packages/spec/src/migrations/registry.ts`: id
`form-view-subform-columns-closed`, `order` 54 (the highest at base
`5dbeb7d7b7` was 53), inserted where its id sorts. It covers the
form-view carrier closure, the D2 conversion
`form-view-subform-columns-canonicalized`, and the identity-only sibling
`inline-grid-column-identity-only-currency-scale-refused`. Each sentence
restates the two entry sources and the conversion source. The list sits
outside the generated markers and is hand-written;
`gen:migration-registry` is a no-op on this diff. A `patch` changeset
for `@objectstack/spec` is included because the rationale string ships
in `dist/migrations`. This is review item 4 of the at-tier record
`5921114874` on #20953. The card stays open, and the seat closes it by
hand.
## Verification at head `8ebaf237c4` (merges origin/main `dff98c1f51`)
- Rationale pins (`step18-rationale-merge`,
`compliance-families-retirement`, `conversions-major18-merge`): 31
passed. `migrations.test.ts` and `inline-grid-column-carriers.test.ts`:
179 passed. Spec local suite: 588 files, 17318 passed. Spec typecheck:
exit 0.
- `check:generated`: all 15 artifacts are up to date after a spec build.
The upgrade guide prints majors up to `PROTOCOL_MAJOR` (17), so it does
not print step 18 and has no diff here.
- `dispatch-gates --ran`: 82 derived, 82 run, 0 NOT-MEASURED.
- Ablation (fragment removed, anchor 1 to 0, restored to the HEAD blob):
no pin went red. The merge test pins the sort order and the joined text;
no test pins this fragment by id.
## Acceptance notes
- The review counted entries without a fragment of their own id: 207 of
253 at `06f079864a`. Fragments are per retirement family, so the number
of families without one is not counted. `carrier:` none named. Noted
here under the filing gate, with no `reach:` measured today. The
generated guide prints major 17 only (`build-upgrade-guide.ts` loops to
`PROTOCOL_MAJOR`, 17 at this head). Step 18's rationale does reach `os
migrate meta --step`, whose default chain ends at major 18
(`packages/cli/src/commands/migrate/meta.ts`). There, a family without a
fragment is left out of the paragraph, not misstated. This was read from
the source and not measured at that door.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Sfe5YjBLwB9J3y8fvm2xq1)_
Co-authored-by: Claude <noreply@anthropic.com>1 parent cf0346e commit 2742e53
2 files changed
Lines changed: 41 additions & 0 deletions
File tree
- .changeset
- packages/spec/src/migrations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5504 | 5504 | | |
5505 | 5505 | | |
5506 | 5506 | | |
| 5507 | + | |
| 5508 | + | |
| 5509 | + | |
| 5510 | + | |
| 5511 | + | |
| 5512 | + | |
| 5513 | + | |
| 5514 | + | |
| 5515 | + | |
| 5516 | + | |
| 5517 | + | |
| 5518 | + | |
| 5519 | + | |
| 5520 | + | |
| 5521 | + | |
| 5522 | + | |
| 5523 | + | |
| 5524 | + | |
| 5525 | + | |
| 5526 | + | |
| 5527 | + | |
| 5528 | + | |
| 5529 | + | |
| 5530 | + | |
| 5531 | + | |
| 5532 | + | |
| 5533 | + | |
| 5534 | + | |
| 5535 | + | |
| 5536 | + | |
| 5537 | + | |
5507 | 5538 | | |
5508 | 5539 | | |
5509 | 5540 | | |
| |||
0 commit comments