Repository navigation
Commit 19c50eb
committed
fix(actions): pin the ledger fake's update dispatch, and declare how the activation door is actually served
Two CI failures, both real.
1. `check-engine-double-contract` — the activation-ledger fake's `update()` did
not route through ObjectQL's own dispatch predicate, so the double could
accept call shapes the engine refuses. Opened with
`assertEngineUpdateDispatch(data, options)` from `@objectstack/metadata-core`
(the predicate's home since #5619; importing objectql's own re-export from
inside objectql would be a self-import), matching the flow twin's fake. The
new pinned coverage is recorded in the pinned ledger via the sanctioned
`--write`; the shrink-only baseline is untouched.
2. `route-ledger-live-mount-parity` (#7526) — the activation door was
"LEDGERED BUT NOT MOUNTED, and DISGUISED". Root-caused on a booted showcase
rather than guessed: nothing registers `/api/v1/actions/_activation/:object/:action`,
and a 3-segment activation path is matched by
`/api/v1/actions/:object/:action/:recordId` with `_activation` bound to
`:object`. It still reaches the activation arm because that mount rebuilds
the dispatch path from its matched params, byte for byte — measured on the
wire: the 2-segment shape answers this door's own 400 naming the required
shape, and a 3-segment undeclared action answers its own 404 ("nothing to
switch off"), neither of which the invocation path can produce; a 4-segment
path resolves to nothing and 404s at the router.
So the honest fix is the declaration, not a second mount: the ledger row
carries `servedBy: /api/v1/actions/:object/:action/:recordId` with the
mechanism written down. Because a `servedBy` note cannot say the arm still
ANSWERS — and the unit suites drive the domain handler directly, which is
why they stayed green through this — the two wire assertions are pinned
end-to-end in the actions dogfood suite, on a boot that already exists.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KWRU3s15AJz7PGW7a7wdCh1 parent 8b01371 commit 19c50eb
4 files changed
Lines changed: 73 additions & 0 deletions
File tree
- packages
- objectql/src
- qa/dogfood/test
- runtime/src
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| |||
61 | 66 | | |
62 | 67 | | |
63 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
64 | 77 | | |
65 | 78 | | |
66 | 79 | | |
| |||
Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
72 | 116 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
| 387 | + | |
387 | 388 | | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
388 | 399 | | |
389 | 400 | | |
390 | 401 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
951 | 951 | | |
952 | 952 | | |
953 | 953 | | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
954 | 959 | | |
955 | 960 | | |
956 | 961 | | |
| |||
0 commit comments