Skip to content

Commit 0a04b88

Browse files
committed
fix(security): the standing-audit double's unread object parameter is named _object
`tsconfig.test.json` runs with `noUnusedParameters`, and the engine-contract patch introduced `update(object, data, options)` whose first argument the double does not read — TS6133 in the test project only, which a src-only `tsc --noEmit` cannot see. The parameter keeps its POSITION, because the object name is argument one on every IDataEngine write door and dropping it would hand the dispatch predicate the wrong arguments. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AhQASwqJr2Z7XfGWUdvnbF
1 parent a228d74 commit 0a04b88

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎packages/plugins/plugin-security/src/platform-admin-standing-audit.test.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,12 @@ function makeQl(
119119
// hand-mirrored guard (`check:engine-double-contract`): a fixture drifting
120120
// to a call shape ObjectQL.update would refuse fails loudly here. Nothing
121121
// in this file updates, and that is exactly why the refusal must be real.
122-
async update(object: string, data: any, options?: any) {
122+
//
123+
// `_object` keeps the door's POSITION — the object name is argument one on
124+
// every `IDataEngine` write — while telling `noUnusedParameters` that not
125+
// reading it is deliberate. Dropping it would shift `data` and `options`
126+
// one place left and hand the dispatch predicate the wrong arguments.
127+
async update(_object: string, data: any, options?: any) {
123128
assertEngineUpdateDispatch(data, options);
124129
return null;
125130
},

0 commit comments

Comments
 (0)