Repository navigation
Commit 042f406
committed
test(driver-sql): type the fixture log sinks so
The level-recording fixture supplies `error`, so its inferred logger type made
`error` REQUIRED — and the no-error-sink twin, whose entire job is to be a sink
without one, then could not extend it (TS2416/TS2322).
Both fixtures now annotate `FakeLogSink`, which spells `error?` exactly as
`SqlDriver` declares it. That is the contract under test, not a workaround: the
optional `error` is the whole reason `logDurabilityFailure` needs a fallback.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XqDQYVU5smx29ts9pAErjaerror stays OPTIONAL (#9609)1 parent c6cff31 commit 042f406
1 file changed
Lines changed: 19 additions & 3 deletions
Lines changed: 19 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
58 | 74 | | |
59 | 75 | | |
60 | 76 | | |
| |||
112 | 128 | | |
113 | 129 | | |
114 | 130 | | |
115 | | - | |
| 131 | + | |
116 | 132 | | |
117 | 133 | | |
118 | 134 | | |
| |||
196 | 212 | | |
197 | 213 | | |
198 | 214 | | |
199 | | - | |
200 | | - | |
| 215 | + | |
| 216 | + | |
201 | 217 | | |
202 | 218 | | |
203 | 219 | | |
| |||
0 commit comments