Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system-dependent line separator when generating a meta model JSON #181

Open
SergeyPoluyanov opened this issue Sep 12, 2017 · 3 comments
Labels
enhancement New feature or request low priority

Comments

@SergeyPoluyanov
Copy link

With core.autocrlf = true for git on Windows the meta model file default.json is checked out with CRLF line endings. ObjectBox gradle plugin generates default.json with LF line endings when building a project, so git considers this file to be modified, however in fact the DB scheme is the same.

Maybe it's possible to workaround this using git configuration I'm not aware of, but I suppose it would be preferable to generate line endings that correspond to the current system.

BTW: are you going to open the code of ObjectBox gradle plugin at some future time? 🙂

@greenrobot
Copy link
Member

Not sure how to tackle this, because not everybody does core.autocrlf = true (e.g. I do not).
And yes, current plans are to open source the gradle plugin once we find the time for some clean up.

@javaherisaber
Copy link

javaherisaber commented Apr 25, 2023

@greenrobot
Any plans for adding a fix for this issue?
It's really annoying to revert the change to default.json file every single time we do a build or checkout another branch

@greenrobot-team
Copy link
Member

greenrobot-team commented May 2, 2023

@javaherisaber As @greenrobot notes:

Not sure how to tackle this, because not everybody does core.autocrlf = true (e.g. I do not).

So even if we add a plugin config option or some auto-detection, that might not work if developers work on different operating systems or have different Git settings. Suggestions welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

4 participants