Lints: use const

Author: greenrobot-team

bin/objectbox.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
+
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ -7,9 +9,9 @@ import 'package:benchapp/time_tracker.dart';
 void main(List<String> arguments) async {
   exitCode = 0; // presume success
 
-  final argDb = 'db';
-  final argCount = 'count';
-  final argRuns = 'runs';
+  const argDb = 'db';
+  const argCount = 'count';
+  const argRuns = 'runs';
 
   final parser = ArgParser()
     ..addOption(argDb, defaultsTo: 'benchmark-db', help: 'database directory')

lib/main.dart

@@ -11,6 +11,7 @@ import 'hive_executor.dart' as hive;
 import 'isar_sync_executor.dart' as isar_sync;
 import 'obx_executor.dart' as obx;
 import 'sqf_executor.dart' as sqf;
+
 // import 'hive_lazy_executor.dart' as hive_lazy;
 import 'time_tracker.dart';
 
@@ -183,7 +184,7 @@ class _MyHomePageState extends State<MyHomePage> {
 
   Future<void> printResult(String value) async {
     setState(() => _result = value);
-    await Future.delayed(Duration(seconds: 0)); // yield to re-render
+    await Future.delayed(const Duration(seconds: 0)); // yield to re-render
   }
 
   /// Waits for the given future to complete. Returns true if the benchmark
@@ -421,13 +422,13 @@ class _MyHomePageState extends State<MyHomePage> {
           mainAxisAlignment: MainAxisAlignment.center,
           children: [
             Row(children: [
-              Spacer(),
+              const Spacer(),
               DropdownButton(
                   value: _db,
                   items: enumDropDownItems(DbEngine.values),
                   onChanged: (DbEngine? value) =>
                       configure(value!, _mode, _indexed)),
-              Spacer(),
+              const Spacer(),
               DropdownButton(
                   value: _mode,
                   // TODO items: enumDropDownItems(Mode.values),
@@ -444,71 +445,70 @@ class _MyHomePageState extends State<MyHomePage> {
                           (mode != Mode.Queries && mode != Mode.QueryById))
                       .toList()),
                   onChanged: (Mode? value) => configure(_db, value!, _indexed)),
-              Spacer(),
-              Text('Index'),
+              const Spacer(),
+              const Text('Index'),
               if (_db == DbEngine.Hive)
-                Text(' not available')
+                const Text(' not available')
               else
                 Switch(
                   value: _indexed,
                   onChanged: (bool value) => configure(_db, _mode, value),
                   activeTrackColor: Colors.yellow,
                   activeColor: Colors.orangeAccent,
                 ),
-              Spacer(),
+              const Spacer(),
             ]),
             Row(children: [
-              Spacer(),
+              const Spacer(),
               Expanded(
                   child: TextField(
                 keyboardType: TextInputType.number,
                 controller: _runsController,
-                decoration: InputDecoration(
+                decoration: const InputDecoration(
                   labelText: 'Runs',
                 ),
               )),
-              if (_mode == Mode.Queries) Spacer(),
+              if (_mode == Mode.Queries) const Spacer(),
               if (_mode == Mode.Queries)
                 Expanded(
                     child: TextField(
                   keyboardType: TextInputType.number,
                   controller: _operationsController,
-                  decoration: InputDecoration(
+                  decoration: const InputDecoration(
                     labelText: 'Operations',
                   ),
                 )),
-              if (_mode == Mode.QueryById) Spacer(),
+              if (_mode == Mode.QueryById) const Spacer(),
               if (_mode == Mode.QueryById)
                 Expanded(
                     child: TextField(
                   keyboardType: TextInputType.number,
                   controller: _resultsController,
-                  decoration: InputDecoration(
+                  decoration: const InputDecoration(
                     labelText: 'Results',
                   ),
                 )),
-              Spacer(),
+              const Spacer(),
               Expanded(
                   child: TextField(
                 keyboardType: TextInputType.number,
                 controller: _objectsController,
-                decoration: InputDecoration(
+                decoration: const InputDecoration(
                   labelText: 'Objects',
                 ),
               )),
-              Spacer(),
+              const Spacer(),
             ]),
-            Spacer(),
+            const Spacer(),
             Text(_result),
-            Spacer(),
+            const Spacer(),
             Container(
-                padding: EdgeInsets.symmetric(horizontal: 30),
+                padding: const EdgeInsets.symmetric(horizontal: 30),
                 child: Table(
-                    border: TableBorder(
-                        horizontalInside:
-                            BorderSide(color: const Color(0x55000000))),
+                    border: const TableBorder(
+                        horizontalInside: BorderSide(color: Color(0x55000000))),
                     children: _resultRows)),
-            Spacer(),
+            const Spacer(),
           ],
         )),
       ),
@@ -518,12 +518,12 @@ class _MyHomePageState extends State<MyHomePage> {
               ? FloatingActionButton(
                   onPressed: _stopBenchmark,
                   tooltip: 'Stop',
-                  child: Icon(Icons.stop),
+                  child: const Icon(Icons.stop),
                 )
               : FloatingActionButton(
                   onPressed: _runBenchmark,
                   tooltip: 'Start',
-                  child: Icon(Icons.play_arrow),
+                  child: const Icon(Icons.play_arrow),
                 ), // This trailing comma makes auto-formatting nicer for build methods.
     );
   }

lib/sqf_executor.dart

@@ -162,7 +162,7 @@ class ExecutorRel<T extends RelSourceEntity> extends ExecutorBaseRel<T> {
   static Future<ExecutorRel<T>> create<T extends RelSourceEntity>(
       TimeTracker tracker, Database db) async {
     final table = T.toString();
-    final tableTarget = 'RelTargetEntity';
+    const tableTarget = 'RelTargetEntity';
 
     await db.execute('''
                   CREATE TABLE $table (