Skip to content

Commit 96535d6

Browse files
marin-mazhejiangxiaomai
authored andcommitted
Fix nullaware anti
1 parent 6f7affd commit 96535d6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

velox/substrait/SubstraitToVeloxPlan.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
242242

243243
// Map join type.
244244
core::JoinType joinType;
245+
bool isNullAwareAntiJoin = false;
245246
switch (sJoin.type()) {
246247
case ::substrait::JoinRel_JoinType::JoinRel_JoinType_JOIN_TYPE_INNER:
247248
joinType = core::JoinType::kInner;
@@ -280,10 +281,9 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
280281
if (sJoin.has_advanced_extension() &&
281282
subParser_->configSetInOptimization(
282283
sJoin.advanced_extension(), "isNullAwareAntiJoin=")) {
283-
joinType = core::JoinType::kNullAwareAnti;
284-
} else {
285-
joinType = core::JoinType::kAnti;
284+
isNullAwareAntiJoin = true;
286285
}
286+
joinType = core::JoinType::kAnti;
287287
break;
288288
}
289289
default:
@@ -334,7 +334,7 @@ core::PlanNodePtr SubstraitVeloxPlanConverter::toVeloxPlan(
334334
return std::make_shared<core::HashJoinNode>(
335335
nextPlanNodeId(),
336336
joinType,
337-
joinType == core::JoinType::kNullAwareAnti ? true : false,
337+
isNullAwareAntiJoin,
338338
leftKeys,
339339
rightKeys,
340340
filter,

0 commit comments

Comments
 (0)