Fallback collect_set in window (#350)

rui-mo · web-flow · commit 68be4e09e214 · 2023-07-06T13:01:57.000+08:00
diff --git a/velox/substrait/SubstraitToVeloxPlanValidator.cpp b/velox/substrait/SubstraitToVeloxPlanValidator.cpp
@@ -471,7 +471,8 @@ bool SubstraitToVeloxPlanValidator::validate(
   }
 
   // Validate supported aggregate functions.
-  std::unordered_set<std::string> unsupportedFuncs = {"collect_list"};
+  std::unordered_set<std::string> unsupportedFuncs = {
+      "collect_list", "collect_set"};
   for (const auto& funcSpec : funcSpecs) {
     auto funcName = subParser_->getSubFunctionName(funcSpec);
     if (unsupportedFuncs.find(funcName) != unsupportedFuncs.end()) {

Original file line number	Diff line number	Diff line change
`@@ -471,7 +471,8 @@ bool SubstraitToVeloxPlanValidator::validate(`
`471`	`471`	`}`
`472`	`472`
`473`	`473`	`// Validate supported aggregate functions.`
`474`		`- std::unordered_set<std::string> unsupportedFuncs = {"collect_list"};`
	`474`	`+ std::unordered_set<std::string> unsupportedFuncs = {`
	`475`	`+ "collect_list", "collect_set"};`
`475`	`476`	`for (const auto& funcSpec : funcSpecs) {`
`476`	`477`	`auto funcName = subParser_->getSubFunctionName(funcSpec);`
`477`	`478`	`if (unsupportedFuncs.find(funcName) != unsupportedFuncs.end()) {`