change dense rank return type to integer (#138)

liujiayi771 · web-flow · commit 25bf3b43646e · 2023-02-28T15:44:58.000+08:00
diff --git a/velox/functions/prestosql/window/Rank.cpp b/velox/functions/prestosql/window/Rank.cpp
@@ -113,7 +113,7 @@ void registerRank(const std::string& name) {
   registerRankInternal<RankType::kRank, int32_t>(name, "integer");
 }
 void registerDenseRank(const std::string& name) {
-  registerRankInternal<RankType::kDenseRank, int64_t>(name, "bigint");
+  registerRankInternal<RankType::kDenseRank, int32_t>(name, "integer");
 }
 void registerPercentRank(const std::string& name) {
   registerRankInternal<RankType::kPercentRank, double>(name, "double");

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ void registerRank(const std::string& name) {`
`113`	`113`	`registerRankInternal<RankType::kRank, int32_t>(name, "integer");`
`114`	`114`	`}`
`115`	`115`	`void registerDenseRank(const std::string& name) {`
`116`		`- registerRankInternal<RankType::kDenseRank, int64_t>(name, "bigint");`
	`116`	`+ registerRankInternal<RankType::kDenseRank, int32_t>(name, "integer");`
`117`	`117`	`}`
`118`	`118`	`void registerPercentRank(const std::string& name) {`
`119`	`119`	`registerRankInternal<RankType::kPercentRank, double>(name, "double");`