Skip to content

Commit 09e6add

Browse files
committed
add test
1 parent ea8ac88 commit 09e6add

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed
379 Bytes
Binary file not shown.

velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,28 @@ TEST_F(ParquetTableScanTest, array) {
241241
{"repeatedInt"}, {}, "", "SELECT repeatedInt FROM tmp");
242242
}
243243

244+
// Failed unit test on Velox array reader.
245+
// Optional array with required elements.
246+
// TEST_F(ParquetTableScanTest, optionalArray) {
247+
// auto vector = makeArrayVector<StringView>({
248+
// {"a", "b"},
249+
// {"c", "d"},
250+
// {"e", "f"},
251+
// });
252+
253+
// loadData(
254+
// getExampleFilePath("part-r-0.parquet"),
255+
// ROW({"_1"}, {ARRAY(VARCHAR())}),
256+
// makeRowVector(
257+
// {"_1"},
258+
// {
259+
// vector,
260+
// }));
261+
262+
// assertSelectWithFilter(
263+
// {"_1"}, {}, "", "SELECT _1 FROM tmp");
264+
// }
265+
244266
// Failed unit test on Velox map reader.
245267
// TEST_F(ParquetTableScanTest, nestedMapWithStruct) {
246268
// auto vector = makeArrayVector<int32_t>({{1, 2, 3}});

0 commit comments

Comments
 (0)