Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues on large files #4

Closed
oakmac opened this issue Nov 20, 2015 · 2 comments
Closed

Performance issues on large files #4

oakmac opened this issue Nov 20, 2015 · 2 comments

Comments

@oakmac
Copy link
Owner

oakmac commented Nov 20, 2015

I noticed some poor performance when using this extension on large files. For some files the extension is basically unusable due to how long it takes to process.

When I was developing atom-parinfer, I tested against cljs.core - which has over 10k lines. Had to come up with some performance hacks to improve Parinfer performance for that threshold.

Mainly:

  1. Only sending the code that had likely changed to Parinfer instead of the whole file. See: this code as well as Issue #9
  2. The use of a small LRU cache to prevent repeated processing.

I'm not sure these are perfect solutions and @shaunlebron has expressed improving performance in the main Parinfer algorithm, but these tricks might be helpful in the meantime.

@oakmac
Copy link
Owner Author

oakmac commented Aug 24, 2016

Since this issue was opened, parinfer.js has been re-written and is substantially faster than the implementation currently being used for this plugin.

atom-parinfer still uses the "parent expression" performance hack described here, although to be honest I'm not sure this is even necessary anymore. Either way, there have been zero complaints from users about speed issues.

FYI

@narma narma assigned narma and unassigned joaomoreno Sep 1, 2016
@shaunlebron
Copy link
Collaborator

fixed by #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants