I'm on the Authors list twice

[illegitimate-egg]

Duplicates

• I have searched the existing issues

Current behavior 😯

Onefetch reports two Authors, when there is only one. Both authors are the same person.

Expected behavior 🤔

Onefetch reports one Author.

Steps to reproduce 🕹

1. git clone https://github.com/illegitimate-egg/ncurses-prime
2. onefetch

Additional context/Screenshots 🔦

Possible Solution 💡

No response

[o2sh]

Hi @illegitimate-egg,

All your commits were not made with the same email address:

To fix it you need to create a .mailmap file a the root of your repo (more info about mailmap) where you can specify the correct mapping.

With this mapping:

You'll get this:

[illegitimate-egg]

Oh, thanks!

[spenserblack]

Do you think it's worth adding this to an FAQ? 🤔

[illegitimate-egg]

Do you think it's worth adding this to an FAQ? 🤔

It's more of a problem with me being inexperienced with git

[spenserblack]

To be fair, I think mailmap isn't a well-known feature 🙂

[o2sh]

Do you think it's worth adding this to an FAQ? 🤔

Hopefully, people should stumble upon this issue before creating a duplicate.

[spenserblack]

Oh yeah, good point 😆

[jtmr05]

The opposite is also happening: git shortlog -nse lists two different entries for the same email address but with different names, one being the Github Public Profile name and the other the actual account username. It would be nicer if entries with the same email address were added together, instead of simply following git shortlog's output.

[beutlich]

Even with having a .mailmap file available I see duplicated authors. Can anyone confirm with this repo?

[spenserblack]

@beutlich Looks like your .mailmap lists every author and their email. The two most common use cases for mailmaps (IMO) is to fix the name mapped to an email, and provide a secondary email (and name) mapped to the author's primary info. For example, with this change alone, you're listed only once, since these are your two most frequently used emails:

diff --git a/.mailmap b/.mailmap
index 864f8ad46..5b7291e7b 100644
--- a/.mailmap
+++ b/.mailmap
@@ -114,8 +114,7 @@ Stephan Ziegler <stephan.ziegler@3ds.com>
 Sven Erik Mattson <svenerik@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
 Thomas Beutlich <beutlich@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
 Thomas Beutlich <beutlich@users.noreply.github.com>
-Thomas Beutlich <modelica@tbeu.de>
-Thomas Beutlich <thomas.beutlich@esi-group.com>
+Thomas Beutlich <modelica@tbeu.de> <thomas.beutlich@esi-group.com>
 Thomas Bödrich <ThomasBoedrich@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
 Volker Waurich <12234403+vwaurich@users.noreply.github.com>
 carlj-w <41286817+carlj-w@users.noreply.github.com>

Also, this would work:

diff --git a/.mailmap b/.mailmap
index 864f8ad46..aede18718 100644
--- a/.mailmap
+++ b/.mailmap
@@ -112,10 +112,9 @@ Stefan Wischhusen <wischhusen@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
 Stefan Wischhusen <wischhusen@xrg-simulation.de>
 Stephan Ziegler <stephan.ziegler@3ds.com>
 Sven Erik Mattson <svenerik@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
-Thomas Beutlich <beutlich@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
-Thomas Beutlich <beutlich@users.noreply.github.com>
-Thomas Beutlich <modelica@tbeu.de>
-Thomas Beutlich <thomas.beutlich@esi-group.com>
+<modelica@tbeu.de> <beutlich@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
+<modelica@tbeu.de> <thomas.beutlich@esi-group.com>
+<modelica@tbeu.de> <beutlich@users.noreply.github.com>
 Thomas Bödrich <ThomasBoedrich@7ce873d0-865f-4ce7-a662-4bb36ea78beb>
 Volker Waurich <12234403+vwaurich@users.noreply.github.com>
 carlj-w <41286817+carlj-w@users.noreply.github.com>

More information here: https://git-scm.com/docs/gitmailmap

AFAIK This behavior is consistent with git shortlog --email.

[beutlich]

Thanks for the fast reply @spenserblack.

I generated that .mailmap file with line-wise author listing based on https://kevin.burke.dev/kevin/easy-maintenance-of-your-authors-file/ and it worked out in git or TortoiseGit.

Is there any chance that onefetch could also consider these line-wise author mapping?

[spenserblack]

See #447 (and the linked PRs/issues in that discussion) for some more context, but I think we're pretty much set on sticking with email as the identifier.

I don't think that script was really intended to generate a .mailmap file -- quickly skimming that page seems to imply it was used to make a human-readable authors document to provide credit to contributors. Since your .mailmap was generated from a git log, I'm not really sure what it's actually accomplishing TBH. By "working out" do you mean "not breaking"? In fact, by updating your .mailmap to map all emails to the same person, I'd say it would fix the linked script by combining duplicates into one user (I tested this out on our own repository, where we have both same name + different email and same email + different name issues in our log 😅).

If you search for .mailmap files you should see that Author Name <primary@example.com> <secondary@example.com> is a popular format. Besides onefetch, I'd say it's a pretty good standard to have a .mailmap when one author changes their info. It will also fix your own git log by providing a canonical email address/name in the author information.

[beutlich]

Thank your for your fast feedback.

By "working out" do you mean "not breaking"?

Sorry for not being excat enough. The given .mailmap file with line-wise authors is correctly taken into account by both

• git command git shortlog -sn --since="25 January 2014"
• TortoiseGit Statistics dialog if set
  

Also, https://git-scm.com/docs/gitmailmap mentions

Joe R. Developer <joe@example.com>
Jane Doe <jane@example.com>
Jane Doe <jane@desktop.(none)>

as the corrected example to fix the names.

Given these points, my expectation was that this kind of formatting is a valid format for .mailmap (even it its original intent of generation was some AUTHORS file).