Add rotations using Euler parameters and MRPs #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 55.57% 59.83% +4.26%
==========================================
Files 55 59 +4
Lines 4763 5530 +767
==========================================
+ Hits 2647 3309 +662
- Misses 2116 2221 +105
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Lots more work needed
Must expand greatly
Cannot use proptest or kani sadly
eul2xf_c uses passive rotation, but that's just super confusing to me. Great source here: https://danceswithcode.net/engineeringnotes/quaternions/quaternions.html
Heap is required due to life time of pointer to u8s. The other option would be to use a Box<Deref<target=[u8]>> but the data is still on the heap... With the Bytes approach, data could be loaded from a pointer with a static lifetime.
…ematics-so3-group
ChristopherRabotin
deleted the
35-structures-and-traits-for-rotation-mathematics-so3-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TODO list is in the issue.
Closes #35