Add possibility to change maximum zoom scale for the ScalingImageView.

[heikkihautala]

No description provided.

[cdzombak]

This could easily be achieved by:

• Making the maximum zoom scale a property on NYTScalingImageView, setting it to 1.0 in the initializer, and using it instead of the hardcoded 1.0
• Either adding a maximumPhotoZoomScale property to NYTPhotosViewController or an optional -photosViewController:maximumZoomScaleForPhoto: method to NYTPhotosViewControllerDelegate. I am not sure offhand which approach is preferable here.
• Finally, using that property or delegate method when creating a NYTPhotoViewController in newPhotoViewControllerForPhoto:.

We would welcome a PR to this effect and any further discussion on the best way to expose this functionality on NYTPhotosViewController.

[heikkihautala]

I made a PR: #51. I decided to go with the delegate approach, because it enables the user to set different maximum zoom scale for each photo if necessary.

[cdzombak]

@heikkihautala thanks! I'll take a look asap.

[cdzombak]

closed by #51

[schystz]

Hi. I don't get the photosViewController:maximumZoomScaleForPhoto: protocol when installing NYTPhotoViewer via Cocoapods. It installs the 0.1.2 version when specifying pod 'NYTPhotoViewer' in the Podfile.

[MichaelSelsky]

That's because version 0.1.2 was released before this feature was added. I'll work on getting a new release on Monday. Until then you can point the most recent changes in this pod by using this line in your Podfile:

pod 'NYTPhotoViewer', :head

[agordeev]

Is this working? I have implemented photosViewController:maximumZoomScaleForPhoto:, but it never gets called.

[cdzombak]

@andrew8712 yes, this was merged in #51 a while ago and is included in recent releases.

Is it possible you're hitting bug #95 which is fixed in v1.1.0?

[agordeev]

No, I use the latest release (1.1.0).

Should I do anything besides implementing this delegate method to achieve max zoom functionality?

[cdzombak]

Should I do anything besides implementing this delegate method to achieve max zoom functionality?

That should be all you need.

No, I use the latest release (1.1.0).

are you using the new designated initializer? It takes a delegate and if you're using a delegate you should use this initializer:

- (instancetype)initWithPhotos:(NSArray <id <NYTPhoto>> * _Nullable)photos initialPhoto:(id <NYTPhoto> _Nullable)initialPhoto delegate:(nullable id <NYTPhotosViewControllerDelegate>)delegate

[agordeev]

Thanks, this worked. Curious, it didn't work this way:

let photosViewController = NYTPhotosViewController(photos: images, initialPhoto: item)
photosViewController.delegate = self

[cdzombak]

Curious, it didn't work this way: …

You're running into #95 .