remove nuke db cli args - only makes sense for sqlite and not pgsql

Author: mmsinclair

nym-data-observatory/src/chain_scraper/mod.rs

@@ -13,11 +13,6 @@ pub(crate) async fn run_chain_scraper(
 ) -> anyhow::Result<PostgresNyxdScraper> {
     let use_best_effort_start_height = args.start_block_height.is_some();
 
-    if args.nuke_db {
-        warn!("☢️☢️☢️ NUKING THE SCRAPER DATABASE");
-        fs::remove_file(config.chain_scraper_connection_string())?;
-    }
-
     let database_storage = config
         .chain_scraper_connection_string
         .clone()

nym-data-observatory/src/cli/commands/run/args.rs

@@ -15,9 +15,6 @@ pub(crate) struct Args {
     #[arg(long, env = NYXD_SCRAPER_START_HEIGHT)]
     pub(crate) start_block_height: Option<u32>,
 
-    #[arg(long, env = NYXD_SCRAPER_UNSAFE_NUKE_DB, default_value = "false")]
-    pub(crate) nuke_db: bool,
-
     /// (Override) Postgres connection string for chain scraper history
     #[arg(long, env = NYM_DATA_OBSERVATORY_DB_URL, alias = "db_url")]
     pub(crate) db_connection_string: Option<String>,

nym-data-observatory/src/cli/commands/run/mod.rs

@@ -123,7 +123,6 @@ pub(crate) async fn execute(args: Args, http_port: u16) -> Result<(), NymDataObs
             w.watch_for_chain_message_types
         );
     }
-    info!("nuke_db: {}", args.nuke_db);
 
     let storage = db::Storage::init(db_connection_string).await?;
     let watcher_pool = storage.pool_owned();

nym-data-observatory/src/env.rs

@@ -16,8 +16,6 @@ pub mod vars {
     pub const NYXD_SCRAPER_USE_BEST_EFFORT_START_HEIGHT: &str =
         "NYXD_SCRAPER_USE_BEST_EFFORT_START_HEIGHT";
 
-    pub const NYXD_SCRAPER_UNSAFE_NUKE_DB: &str = "NYXD_SCRAPER_UNSAFE_NUKE_DB";
-
     pub const NYM_DATA_OBSERVATORY_ID_ARG: &str = "NYM_DATA_OBSERVATORY_ID";
     pub const NYM_DATA_OBSERVATORY_OUTPUT_ARG: &str = "NYM_DATA_OBSERVATORY_OUTPUT";