Skip to content

remove "web" from reddit share url #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

monika-with-a-k
Copy link

@monika-with-a-k monika-with-a-k commented Mar 28, 2025

Remove "web" element from path for RedditShareButton

Current issue:

Fix:

Copy link

changeset-bot bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: 99146ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-share Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@monika-with-a-k monika-with-a-k marked this pull request as ready for review March 28, 2025 21:18
Copy link
Owner

@nygardk nygardk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the contribution.

Not the that /web was included in the path recently in this PR.

Unfortunately, I don't have the time to investigate what is the correct url after all. It might depend on the case. Nevertheless, it would be good that we don't end up going back-and-forth with the url in different releases.

Any chance you could test the case "Verified that the link is now correctly populated in Reddit share previews (#547 )" and think of a solution that would in all cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants