Error handling in case Hyper-V VM Notes field is not readable as XML.

Author: raandree

AutomatedLab/AutomatedLab.psm1

@@ -1217,7 +1217,11 @@ function Remove-Lab
             {
                 $machineMetadata = Get-LWHypervVMDescription -ComputerName $machine -ErrorAction SilentlyContinue
                 $vm = Get-VM -Name $machine -ErrorAction SilentlyContinue
-                if ($machineMetadata.LabName -ne $labName -and $vm)
+                if (-not $machineMetadata)
+                {
+                    Write-Error -Message "Cannot remove machine '$machine' because lab meta data could not be retrieved"
+                }
+                elseif ($machineMetadata.LabName -ne $labName -and $vm)
                 {
                     Write-Error -Message "Cannot remove machine '$machine' because it does not belong to this lab"
                 }

AutomatedLabWorker/AutomatedLabWorkerVirtualMachines.psm1

@@ -1684,10 +1684,16 @@ function Get-LWHypervVMDescription
 
     $type = Get-Type -GenericType AutomatedLab.DictionaryXmlStore -T String,String
 
-    $importMethodInfo = $type.GetMethod('ImportFromString', [System.Reflection.BindingFlags]::Public -bor [System.Reflection.BindingFlags]::Static)
-    $dictionary = $importMethodInfo.Invoke($null, $vm.Notes)
-        
-    $dictionary
+    try
+    {
+        $importMethodInfo = $type.GetMethod('ImportFromString', [System.Reflection.BindingFlags]::Public -bor [System.Reflection.BindingFlags]::Static)
+        $dictionary = $importMethodInfo.Invoke($null, $vm.Notes)   
+        $dictionary
+    }
+    catch
+    {
+        Write-ScreenInfo -Message "The notes field of the virtual machine '$ComputerName' could not be read as XML" -Type Warning
+    }
 
     Write-LogFunctionExit
 }