Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Commit f778843

Browse files
committed
refactor(nxext): refactor packages
1 parent 1ff5540 commit f778843

File tree

63 files changed

+430
-582
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+430
-582
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
# Cache node_modules
2525
- uses: actions/setup-node@v3
2626
with:
27-
node-version: 18
27+
node-version: 18.18
2828
cache: 'pnpm'
2929
- uses: actions/cache@v4
3030
with:
@@ -34,8 +34,13 @@ jobs:
3434
# Connect your workspace on nx.app and uncomment this to enable task distribution.
3535
# The "--stop-agents-after" is optional, but allows idle agents to shut down once the "build" targets have been requested
3636
- run: pnpm install --no-frozen-lockfile
37-
- uses: nrwl/nx-set-shas@v4
37+
- uses:
38+
nrwl/nx-set-shas@v3
39+
# This line is needed for nx affected to work when CI is running on a PR
40+
- run: git branch --track main origin/main
41+
if: ${{ github.event_name == 'pull_request' }}
42+
#- uses: nrwl/nx-set-shas@v4
3843
#- run: pnpm exec nx-cloud start-ci-run --distribute-on="5 linux-medium-js" --stop-agents-after="build"
3944

40-
- run: pnpm exec nx-cloud record -- nx format:check
41-
- run: pnpm exec nx affected -t lint test build
45+
#- run: pnpm exec nx-cloud record -- nx format:check
46+
- run: pnpm exec nx affected -t lint test build e2e

.prettierignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,6 @@
77
/build
88

99
/.nx/cache
10+
11+
1012
pnpm-lock.yaml

docs/docs/ionic-angular/generators.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Skip formatting files.
7070

7171
#### standalone
7272

73-
Default: `false`
73+
Default: `true`
7474

7575
Type: `boolean`
7676

jest.preset.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
const nxPreset = require('@nx/jest/preset').default;
2+
23
module.exports = {
34
...nxPreset,
45
testTimeout: 500000,

nx.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@
118118
"!{projectRoot}/eslint.config.js"
119119
]
120120
},
121-
"nxCloudAccessToken": "NTlhMGE3ZTYtYjk5OC00Mzc5LWE2ZTAtNzE4ODEzNDY5MjlmfHJlYWQ=",
122121
"parallel": 1,
123122
"pluginsConfig": {
124123
"@nx/js": {

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
"@nx/cypress": "18.3.1",
5959
"@nx/devkit": "18.3.1",
6060
"@nx/eslint": "18.3.1",
61+
"@nx/webpack": "18.3.1",
6162
"@nx/eslint-plugin": "18.3.1",
6263
"@nx/jest": "18.3.1",
6364
"@nx/js": "18.3.1",
@@ -128,10 +129,10 @@
128129
},
129130
"lint-staged": {
130131
"nx.json": [
131-
"yarn format --uncommitted"
132+
"pnpm format --uncommitted"
132133
],
133134
"*.{js,json,css,scss,md,ts,html,graphql}": [
134-
"yarn format --uncommitted"
135+
"pnpm format --uncommitted"
135136
]
136137
},
137138
"config": {

packages/capacitor/package.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
{
22
"name": "@nxext/capacitor",
3-
"version": "18.0.4",
3+
"version": "18.0.0",
44
"description": "An Nx plugin for developing cross-platform applications using Capacitor",
5-
"author": {
6-
"name": "Devin Shoemaker",
7-
"email": "devinshoe@gmail.com"
8-
},
95
"homepage": "https://nxext.github.io/nx-extensions-ionic/docs/capacitor/getting-started.html",
106
"repository": {
117
"type": "git",
@@ -28,5 +24,7 @@
2824
"ignore": "^5.3.1",
2925
"tslib": "^2.3.0"
3026
},
31-
"peerDependencies": {}
27+
"peerDependencies": {
28+
"@nx/web": "^18.3.0"
29+
}
3230
}

packages/capacitor/plugin.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/*
2+
export {
3+
createNodes,
4+
PlaywrightPluginOptions,
5+
createDependencies,
6+
} from './src/plugins/plugin';
7+
*/

packages/capacitor/src/generators/capacitor-project/generator.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,3 @@ export async function capacitorProjectGenerator(
2626
}
2727

2828
export default capacitorProjectGenerator;
29-
export const capacitorProjectSchematic = convertNxGenerator(
30-
capacitorProjectGenerator
31-
);
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
xdescribe('Plugin', () => {
2+
beforeEach(() => {});
3+
4+
it('', async () => {});
5+
});

0 commit comments

Comments
 (0)