Overview of reviewed/fixed/applied issues/PRs of the abandoned upstream (fixed on nxadm/tail)

[nxadm]

This repository rebooted the development of tail and we mainly focus on issues and PR on nxadm/tail. However, we try follow and fix "historical" issues and PRs from the dormant repository. Because of the many changes between the frozen state of hpcloud/tail and the new commits on this repo, many issues have already been fixed and need verification or a test-case. This also means that upstream PRs no longer can be applied as is. The changes are cherry-picked and their authors referred in the commit message if possible. Feel free to amend changes or issue a new PR if you're an author.

• Tailing a non-existent file causes the first line to be dropped hpcloud/tail#11: fixed by merged PRs.
• gzip support hpcloud/tail#13: NA (request for enhancement: gz files are not tailed, but archived although it may be considered later is tail is used a replacement for zcat).
• Inotify tail doesn't work when a file is quickly recreated hpcloud/tail#21: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can no longer reproduce, see Fix tailing logs stops working after sometimes tdevelioglu/prometheus-nginx-log-exporter#4.
• changes after reaching EOF are not detected with fsnotify and polling on win32 hpcloud/tail#31: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can no longer reproduce.
• Tests fail on Windows hpcloud/tail#34: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), tests no pass on MS Windows. Windows support warning removed from Readme.
• Add line position to Line hpcloud/tail#49: fixed (imported PR added line num to Line struct hpcloud/tail#149 from @mezzi) .
• Deadlock when using fsnotify on Windows hpcloud/tail#54: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can not longer reproduce.
• [Feature Request] Support for line number seeking hpcloud/tail#83: the addition of Line.Num with the line number allow to easily implement this on client code by skipping lines < n.
• Exits the the program without any error once the File is deleted/rotated on Ubuntu x86_64 GNU/Linux hpcloud/tail#90: upstream fsnotify bug Missing Remove Event when file handle open before for Linux fsnotify/fsnotify#194, fixed by Do not suppress Chmod on non-existent file fsnotify/fsnotify#260 (to be merged), validated in branch https://github.com/nxadm/tail/tree/bug122.
• Add FileStat() hpcloud/tail#92: rejected (use case not completely clear, can be merged later).
• tail.Stop() throws "all goroutines are asleep - deadlock!" hpcloud/tail#93: fixed (PR Fix deadlock when stopping on non-empty file/buffer #7 from @lukedirtwalker).
• Log rotation bug with polling watcher hpcloud/tail#94: already merged.
• tailFile: leakybucket algo err hpcloud/tail#95:
• Import Issue hpcloud/tail#96: fixed (moved code to go modules and version tags)
• Tailing stops (gets stuck) in certain conditions hpcloud/tail#97: already merged.
• Lost NotifyDeleted()/NotifyTruncated()/NotifyModified() Signals hpcloud/tail#98: already merged.
• Add a context for cancellation? hpcloud/tail#104: the Stop() should stop the thread. Using context is a possibility in a future v2.
• Config not properly reapplied on reopen? hpcloud/tail#107:
• Feature/line seeker hpcloud/tail#108: rejected (implements a similar functionality as hpcloud#149 + external dependency).
• [Question] events notification hpcloud/tail#109: NA (information request about fsnotify)
• add lock around tail.reader to prevent race hpcloud/tail#114: merged.
• ensure the watcher has started before we read hpcloud/tail#116: NA (already implemented).
• Windows watch isnotexist file, then create it and write some text, but can't print the text hpcloud/tail#117: while hpcloud/tail only supports Windows through polling, nxadm/tail also support fsnotify (default among all the supported OSes).
• remove unwanted log message hpcloud/tail#120: merged.
• Does not trim dos newlines correctly. hpcloud/tail#121: fixed (can not reproduce after changes in this repo).
• does not detect file that has been deleted and recreated hpcloud/tail#122: NA (same bug as hpcloud#90).
• Add "tail -n" functionality hpcloud/tail#123: rejected: the addition of Line.Num with the line number allow to easily implement this on client code by skipping lines < n.
• does not detect file that has been deleted and recreated when use Ino… hpcloud/tail#125: rejected (PR for vendored library, not for tail).
• Solved the problem for never return the last line if it's not followed by a newline hpcloud/tail#126: merged.
• Is the log file guaranteed to be read until the end before being reopened? hpcloud/tail#127: NA (request for information: No, if the file is deleted, it will be reopened).
• Compile-able code in readme hpcloud/tail#128: merged.
• Don't block on tail.Lines on shutdown hpcloud/tail#129: merged.
• small change to comment wording. hpcloud/tail#130: merged.
• Remove deprecated os.SEEK consts hpcloud/tail#131: merged.
• Performance hpcloud/tail#132: NA (request available information)
• removed spurious newlines from log messages hpcloud/tail#133: merged.
• File (descriptor) not closed upon deletion hpcloud/tail#134: NA (same bug as hpcloud#90).
• Allow to tail named pipes hpcloud/tail#135: rejected (PR results in errors when a file does not yet exist, see Unable to stat error since v0.6.1 jwilder/dockerize#112).
• error trying example hpcloud/tail#142: fixed (example compiles now).
• loss log hpcloud/tail#144: NA (request for information: responsibility of logrotation program, e.g. copytruncate in logrotate).
• lost logs when append data quickly after truncate hpcloud/tail#145: already merged.
• Please distribute the tag contains fixed fsnotify relocation commit hpcloud/tail#146: fixed (moved code to go modules and version tags).
• added line num to Line struct hpcloud/tail#149: merged.
• Is this repo looking for a maintainer? hpcloud/tail#150: NA (question about upstream state).
• Test fails on aarch64 hpcloud/tail#151: fixed (nxadm/tail uses go modules and more recent dependencies), tested under qemu (Linux 4da9abb41a67 5.8.0-40-generic Bump github.com/fsnotify/fsnotify from 1.5.1 to 1.5.4 #45-Ubuntu SMP Fri Jan 15 11:05:36 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux).
• DRYing up code with existing variable hpcloud/tail#152: merged
• Calling Tail.Cleanup can prevent future tailing hpcloud/tail#153: behaviour documented.
• lost logs when log rotated  hpcloud/tail#154: NA (request for information: responsibility of logrotation program, e.g. copytruncate in logrotate).
• tail on file that is regularly written to can fail due to file being locked (on Windows) hpcloud/tail#157: Request for information (Logparser/tail input on Windows stops sendings logs due to file being locked influxdata/telegraf#6539).
• Hello, I want to receive a notification when deleting a file or directory. What should I do hpcloud/tail#158: NA (question about fsnotify).
• remove vendor, rename imports for fsnotify hpcloud/tail#159: already implemented, vendor kept for now for older go releases.
• Export EOF detection  hpcloud/tail#160: fixed (addressed by PR Added seekinfo to Tail #9).
• Doesn't compile for Dragonfly or Illumos hpcloud/tail#161: fixed (addressed by merging PR hpcloud#162 and other changes. Downstream projects like greenplum-db/gpbackup, owncloud/ocis and asim/go-micro build on Solaris, Illunimos and DragonFly).
• Simplify non-Windows build tag hpcloud/tail#162: merged.
• Don’t block on write if we’ve been killed hpcloud/tail#163: already implemented.
• waiting for file to appear doesn't appear if file isn't closed hpcloud/tail#164: NA (the behaviour is normal: if the file is not closed (saved) fsnotify will not pick up the change).
• Accurate 'offset' hpcloud/tail#165: rejected: each Line in the Lines channels has already a Seekinfo and Filenumber.
• Add DragonFlyBSD support hpcloud/tail#166: already implemented.
• Enable illumos support and other posix unixes hpcloud/tail#167: already implemented.
• fsnotify has moved away from gopkg.in hpcloud/tail#168: fixed (nxadm/tail uses go modules).
• Fixing #168 hpcloud/tail#169: already implemented.
• Support Go modules hpcloud/tail#171: fixed (nxadm/tail uses go modules).
• Fixup build tags hpcloud/tail#173: already implemented.
• Can't tail multiple file hpcloud/tail#174: NA (question about API).
• tail.Config ReOpen abnormal hpcloud/tail#176: NA (not a bug, question about API: once EOF is reached it needs to be reopened),
• error: reference to undefined identifier 'syscall.SizeofInotifyEvent' (gollvm; 1.15.2) hpcloud/tail#177: NA (llgo was dropped from LLVM).
• cannot find module providing package gopkg.in/fsnotify.v1 hpcloud/tail#178: fixed (nxadm/tail uses go modules).
• how to close tails goroutine  hpcloud/tail#179: NA (question about API).
• V1.0.2 hpcloud/tail#180: already implemented.
• fsnotify doesn't work with Windows, polling does hpcloud/tail#181: Fixed on nxadm/tail by changes for Tests fail on Windows hpcloud/tail#34.
• Add instructions to make it work with Windows hpcloud/tail#182: NA (already fixed).
• Update API Documentation link in README hpcloud/tail#183: NA (already fixed).
• Updated to go module hpcloud/tail#184: NA (already fixed).

[justinsantoro]

how about hpcloud/tail#54?

[nxadm]

@justinsantoro Do you have the problem with this fork? nxadm/tail uses the latest fsnotify (1.4.9). If the problem still exists, please open an issue on this repo (I will hide the comments on this overview ticket).