Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .npmignore #1447

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Update .npmignore #1447

merged 1 commit into from
Mar 23, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

ljharb
ljharb reviewed Mar 22, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package isn't published on npm, so this file could actually just be deleted.

Also node_modules and .git (and i think npm-debug.log) are always ignored?

@PeterDaveHello
Copy link
Collaborator Author

Yeah you're right, I forgot that, so would you like me update the PR to remove it?

@ljharb
Copy link
Member

ljharb commented Mar 22, 2017

Yes, 8e0406e#diff-0fd4ef892d9d4990033701887c2f9bcc is the commit that added it, and it was never published. Let's delete it.

@PeterDaveHello
Copy link
Collaborator Author

Done.

@ljharb ljharb merged commit ccd9697 into nvm-sh:master Mar 23, 2017
@PeterDaveHello PeterDaveHello deleted the npmignore branch March 23, 2017 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterDaveHello @ljharb