-
Notifications
You must be signed in to change notification settings - Fork 271
Configurable source selector entries #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable source selector entries #877
Conversation
|
I might consider this a breaking change as even though I added the migration path from |
|
Also, I am not terribly keen on |
I think it's a good name. |
- replaces `source_selector.tab_labels` with `source_selector.sources` - see nvim-neo-tree/neo-tree.nvim#877
RE: #479
Replaces
source_selector.tab_labelswithsource_selector.sources.Why? This allows users to have much more choice over the things that are displayed in their source selector. Previously, all sources in Neo-tree were added to the source selector and there was no way to remove any of them. This will get especially painful as Neo-tree grows and more developers write sources for it.
Additionally I added some logic to ensure that if
source_selectoris active, (IE one of the display bar options is enabled), that the first option in source selector is set to thedefault_sourceso that when users execute:Neotree, their source selector properly displays the first item in the sources.Lastly, I fixed a few logs that had invalid function names in them, and updated the name of a mispelled variable because it annoyed me lol.
Please let me know your feedback!
Tagging users from #479 that participated as that PR was closed:
@cseickel @mrbjarksen @pysan3 @mehalter