feat: add fuzzy_finder_mappings to customize mappings for filter popup in fuzzy_finder_mode #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@adoyle-h While this certainly works, it seems a little rushed. For one, it doesn't make sense for the fuzzy finder mappings config to be at the root level of the config when it only applies to the filesystem source. Also, you are exposing a lot of internal implementation details with the arguments being passed and your example. It would probably be better to have a mappings config for the filter popup that is similar to the mappings used on the main window. In this particular example, the logic for how the focus is moved up or down should not be exposed to the end user. We should be giving them ready made command names that they just need to provide the mapping(s) for. |
Contributor
Author
|
All fixed. |
adoyle-h
force-pushed
the
feat/fuzzy_finder_mappings
branch
from
9b6ab34 to
fc3787e
Compare
adoyle-h
changed the title
…r popup in fuzzy_finder_mode related issue: nvim-neo-tree#451 (comment)
adoyle-h
force-pushed
the
feat/fuzzy_finder_mappings
branch
from
fc3787e to
dd25267
Compare
cseickel
approved these changes
Mar 21, 2023
|
Works very well, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #451 (comment)