fix: compatibility with 0.10 extmark sign #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
suggested changes
Dec 17, 2023
Contributor
wookayin
left a comment
wookayin
left a comment
There was a problem hiding this comment.
This would need be tested more comprehensively in both versions
Co-authored-by: Jongwook Choi <wookayin@gmail.com>
Contributor
Author
cseickel
approved these changes
Dec 24, 2023
Contributor
cseickel
left a comment
cseickel
left a comment
There was a problem hiding this comment.
Sorry for the delay here. I held off because a test was failing, but I realize that it is just a flaky test that needs to be fixed so I'll push this through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After neovim/neovim#26193 , the internal implementation of the diagnostic signs changed to the new extmark-based sign,
sign_getdefinewill no longer work.