fix(renderer): regression in close logic (#1901)

Author: pynappo

lua/neo-tree/ui/renderer.lua

@@ -113,17 +113,11 @@ M.close = function(state, focus_prior_window)
   if focus_prior_window == nil then
     focus_prior_window = true
   end
-  if not M.window_exists(state) then
-    return false
-  end
 
-  log.debug("Closing window, but saving position first.")
-  M.position.save(state, true)
-  local closed = false
-  -- if bufnr is different then we expect, then it was taken over by
-  -- another buffer, so we can't delete it now
-  if vim.api.nvim_win_get_buf(state.winid) == state.bufnr then
-    closed = true
+  local window_existed = M.window_exists(state)
+  if window_existed then
+    log.debug("Closing window, but saving position first.")
+    M.position.save(state, true)
     if state.current_position == "current" then
       -- we are going to hide the buffer instead of closing the window
       local new_buf = vim.fn.bufnr("#")
@@ -155,8 +149,8 @@ M.close = function(state, focus_prior_window)
       events.fire_event(events.NEO_TREE_WINDOW_AFTER_CLOSE, args)
     end
   end
-
   state.winid = nil
+
   local bufnr = state.bufnr or 0
   if bufnr > 0 and vim.api.nvim_buf_is_valid(bufnr) then
     state.bufnr = nil
@@ -167,7 +161,7 @@ M.close = function(state, focus_prior_window)
       end)()
     end
   end
-  return closed
+  return window_existed
 end
 
 M.close_floating_window = function(source_name)
@@ -1258,7 +1252,6 @@ M.window_exists = function(state)
 
   local buf_position = vim.b[bufnr].neo_tree_position
   if buf_position ~= position then
-    log.trace("pos won't work")
     return false
   end
   return window_exists