fix(files): fixes #48, test for max-results support in fd before using it, schedule_wrap log statements to the console

Author: cseickel

doc/neo-tree.txt

@@ -241,12 +241,14 @@ require("neo-tree").setup({
         ["p"] = "paste_from_clipboard",
       }
     },
+    --find_command = "fd" -- if not specified, it will test for fd, fdfind, find, or where
     search_limit = 50, -- max number of search results when using filters
     filters = {
       show_hidden = false,
       respect_gitignore = true,
     },
     bind_to_cwd = true, -- true creates a 2-way binding between vim's cwd and neo-tree's root
+    --
     -- The components section provides custom functions that may be called by 
     -- the renderers below. Each componment is a function that takes the
     -- following arguments:

lua/neo-tree/log.lua

@@ -6,6 +6,7 @@
 -- This library is free software; you can redistribute it and/or modify it
 -- under the terms of the MIT license. See LICENSE for details.
 
+local vim = vim
 -- User configuration section
 local default_config = {
   -- Name of the plugin. Prepended to log messages
@@ -66,7 +67,11 @@ log.new = function(config, standalone)
       end
       config.use_file = false
     else
-      obj.outfile = file or outfile
+      if type(file) == "string" then
+        obj.outfile = file
+      else
+        obj.outfile = outfile
+      end
       config.use_file = true
       if not quiet then
         obj.info("[neo-tree] Logging to file: " .. obj.outfile)
@@ -137,26 +142,28 @@ log.new = function(config, standalone)
 
     -- Output to console
     if config.use_console and level > 2 then
-      local console_string = string.format(
-        "[%-6s%s] %s: %s",
-        nameupper,
-        os.date("%H:%M:%S"),
-        lineinfo,
-        msg
-      )
-
-      if config.highlights and level_config.hl then
-        vim.cmd(string.format("echohl %s", level_config.hl))
-      end
+      vim.schedule(function()
+        local console_string = string.format(
+          "[%-6s%s] %s: %s",
+          nameupper,
+          os.date("%H:%M:%S"),
+          lineinfo,
+          msg
+        )
+
+        if config.highlights and level_config.hl then
+          vim.cmd(string.format("echohl %s", level_config.hl))
+        end
 
-      local split_console = vim.split(console_string, "\n")
-      for _, v in ipairs(split_console) do
-        vim.cmd(string.format([[echom "[%s] %s"]], config.plugin, vim.fn.escape(v, '"')))
-      end
+        local split_console = vim.split(console_string, "\n")
+        for _, v in ipairs(split_console) do
+          vim.cmd(string.format([[echom "[%s] %s"]], config.plugin, vim.fn.escape(v, '"')))
+        end
 
-      if config.highlights and level_config.hl then
-        vim.cmd("echohl NONE")
-      end
+        if config.highlights and level_config.hl then
+          vim.cmd("echohl NONE")
+        end
+      end)
     end
   end
 

lua/neo-tree/sources/filesystem/lib/filter_external.lua

@@ -1,10 +1,29 @@
 local vim = vim
+local log = require("neo-tree.log")
 local Job = require("plenary.job")
 
 local M = {}
+local fd_supports_max_results = nil
+
+local test_for_max_results = function(cmd)
+  if fd_supports_max_results == nil then
+    if cmd == "fd" or cmd == "fdfind" then
+      --test if it supports the max-results option
+      local test = vim.fn.system(cmd .. " this_is_only_a_test --max-depth=1 --max-results=1")
+      if test:match("^error:") then
+        fd_supports_max_results = false
+        log.debug(cmd, "does NOT support max-results")
+      else
+        fd_supports_max_results = true
+        log.debug(cmd, "supports max-results")
+      end
+    end
+  end
+end
 
 local get_find_command = function(state)
   if state.find_command then
+    test_for_max_results(state.find_command)
     return state.find_command
   end
 
@@ -17,6 +36,8 @@ local get_find_command = function(state)
   elseif 1 == vim.fn.executable("where") then
     state.find_command = "where"
   end
+
+  test_for_max_results(state.find_command)
   return state.find_command
 end
 
@@ -47,7 +68,9 @@ M.find_files = function(opts)
     end
     append("--glob", term, path)
     append("--color", "never")
-    append("--max-results", limit)
+    if fd_supports_max_results then
+      append("--max-results", limit)
+    end
   elseif cmd == "find" then
     append(path)
     append("-type", "f,d")