Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default kind_labels to CompletionItemKind #52

Open
wbthomason opened this issue Apr 9, 2021 · 2 comments
Open

Default kind_labels to CompletionItemKind #52

wbthomason opened this issue Apr 9, 2021 · 2 comments

Comments

@wbthomason
Copy link
Collaborator

Per discussion with @Shatur95 in #49

@Shatur
Copy link
Contributor

Shatur commented Apr 9, 2021

Does anyone need to have kind_labels empty? If not, then we can read CompletionItemKind if kind_labels is not set.
Or, alternatively, it could be an additional boolean option.

@dhruvmanila
Copy link
Contributor

You can do this: if the kind_labels field is nil then default to CompletionItemKind otherwise use that and if the user does not want any labels then they can enter an empty table like kind_labels = {}.

Thinking more about it, I won't prefer to use the default. For CompletionItemKind, I have set it up like <icon> <kind>:

Screenshot 2021-05-19 at 21 15 33

And for lsp-status plugin which I'm using in the statusline, I have set it up like <icon>

Screenshot 2021-05-19 at 21 15 58

I think most people would prefer the verbose version for the completion menu and icon only version for the statusline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants