Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for Collaborators #150

Open
akinsho opened this issue Jun 7, 2022 · 24 comments
Open

Looking for Collaborators #150

akinsho opened this issue Jun 7, 2022 · 24 comments

Comments

@akinsho
Copy link
Collaborator

akinsho commented Jun 7, 2022

I'm looking for anyone(or multiple people) working with neovim in flutter regularly who is/are willing to help maintain this plugin. I've become increasingly busy with other plugins and work, and am actually not working with flutter in my day job any more (having changed roles).

So would be good to get some more people who are more up to date on developments to help pitch in. Is a new feature coming out? Has there been a change in the LSP spec or the LSP server

This plugin is fairly low effort since the number of nvim users working in flutter is not huge and the LSP spec doesn't move very quickly.

If you're interested, please leave a comment

@akinsho akinsho pinned this issue Jun 7, 2022
@sonu405

This comment was marked as off-topic.

@akinsho

This comment was marked as resolved.

@Thesmader
Copy link
Collaborator

Hi @akinsho. I am interested in helping maintain this plugin. However, I have fairly less experience developing plugins for neovim. However, I am willing to learn if I can get some help getting started. I rely on this plugin for editing code at my job and for personal projects. Would be awesome to help maintain it

@akinsho
Copy link
Collaborator Author

akinsho commented Jun 12, 2022

@Thesmader that fantastic 👍🏿 thanks for reaching out. So I plan on writing a contributing.md that goes over how the plugin works internally, and I'll link to some guides for lua as well. As far as languages go, it's definitely simpler than dart, so shouldn't be hard to pick up. Probably knowing the nvim API is the most involved bit, but you don't have to learn that, you can always just search help and see what comes up.

I'll add you as a collaborator on the repo 🥇

@avatarnguyen
Copy link

Like @Thesmader I don't have any lua knowledge yet but would like to learn. Because I am using this plugin everyday now, would love to contribute and help maintain as well.

@akinsho
Copy link
Collaborator Author

akinsho commented Jun 21, 2022

@avatarnguyen this is great news I'd greatly appreciate the help. I'm on holiday atm but once I'm back I'll set up the contribution docs and get you set up 👍🏿

@rlch
Copy link
Collaborator

rlch commented Jun 21, 2022

Hey @akinsho! I'm also strapped for time, but I would love to help out where possible. I interact with Flutter regularly for work, and have been tinkering with Lua for quite a while now.

@dphaldes
Copy link

I use flutter a lot and would love to help in whatever way possible!

@barungh
Copy link

barungh commented Jun 25, 2022

@Thesmader that fantastic 👍🏿 thanks for reaching out. So I plan on writing a contributing.md that goes over how the plugin works internally, and I'll link to some guides for lua as well. As far as languages go, it's definitely simpler than dart, so shouldn't be hard to pick up. Probably knowing the nvim API is the most involved bit, but you don't have to learn that, you can always just search help and see what comes up.

I'll add you as a collaborator on the repo 🥇

If I get help and guiding document, I will help to maintain it. Thank You.

@sidlatau
Copy link
Collaborator

Hi, @akinsho, thanks for the great plugin! I am using flutter daily, so I am willing to help to maintain the plugin too :)

@akinsho
Copy link
Collaborator Author

akinsho commented Jul 2, 2022

@sidlatau @rlch I've added you both as collaborators as well as you've both contributed quite a bit over time 👍🏿. Huge thanks to everyone else that has stepped up 🙌🏿. I think in terms of people to add as collaborators, rather than adding 5-6+ people, I think this plugin would probably benefit most from people raising issues and then PRs to tackle things that they want to see added, my hope is that it gets to a point where changes aren't really dependent on me after a while as long as the solutions are well thought through and reviewed by collaborators.

I'm still trying to find the time to document how this plugin works and write up a contributing.md but things off the top of my head that people could help contribute would be

  • Vim help docs, either written manually or generated using one of the many tools. I personally think handwritten is best, but the most time-consuming.
    * Re-factoring this plugin to use nvim-0.7 features (Largely done now)
    - Removing the autocommand workarounds and using the builtin API
    - Removing the command workarounds and using the builtin API
  • Looking at the dart LSP spec and seeing if any new things have been added such as color presentation which was added and incorporated here a while ago.

@tudor07
Copy link

tudor07 commented Jul 20, 2022

Will you still add that contributing.md file? It would be really helpful for any future maintainers.

@akinsho
Copy link
Collaborator Author

akinsho commented Jul 20, 2022

@tudor07 I plan to when I have some time, kind of spread way too thin across quite a few plugins, and still trying to do other non-neovim stuff in my free time so, never feels like there's a moment. I'll start the document and if anyone has interacted to bits of the plugin they can feel free to add some descriptive section on the bits they know such as the fvm feature which @rlch added a while back, tbh I still haven't ever really properly used fvm so that bit is still somewhat unknown to me

@akinsho
Copy link
Collaborator Author

akinsho commented Jul 20, 2022

It's also probably worth mentioning that as far as lua plugins go, this plugin isn't particularly complex. I don't think it's any more complex, if not significantly less so, than a small dart application, so should in theory be easy to read any single module and see how it behaves. Lua is also not a very complex language, if anyone is interested in contributing, I would suggest to start by just reading the content of the module whose name sounds most closely related to what you want to contribute.

@JordanllHarper
Copy link
Contributor

Hello! I'm using this at my job as well and would be interested in helping out. I have less experience than other people at developing plugins but am willing to learn!

@jonasbadstuebner
Copy link
Contributor

Hey there, @akinsho, if you are still looking for people that want to improve stuff, I would be interested in keeping this plugin working. I don't have any experience developing nvim-plugins, but I am sure we can figure everything out as a community.

I'm will be using this plugin a lot in the future, as I recently switched to neovim and am developing an App in my free time.
If you have enough people already, this would also be fine of course!

@akinsho
Copy link
Collaborator Author

akinsho commented Mar 26, 2024

@jonasbadstuebner a good way to start is to feel free to raise any prs to fix any bugs you're finding in your daily usage, or add any new features in and either myself or @sidlatau Will have a look. When we have time, overtime and contributions it will become easier. Add things in or fix things

@akinsho
Copy link
Collaborator Author

akinsho commented Aug 12, 2024

@sidlatau and anyone else subscribed to this issue. I've decided to try to find someone to take over maintenance of this plugin. I haven't worked with dart/flutter for the last few years at this point and it's looking less likely I will in the coming x months/years so I think it'd be better for someone with more time and more flutter context to take over this project. I might spin this out into another issue soon but I'm essentially gonna keep this or the successor issue open for a few months (read 2 max) and if I don't find any takers I'll archive this plugin.

@sidlatau
Copy link
Collaborator

@akinsho I use this plugin daily, so I am willing to spend my time to keep it working. As you mentioned previously it does not require much maintenance but I see it may require some changes for new language features like macros ("Go to augmentation/Go to augmented", see: Dart-Code/Dart-Code@ff99a8c).

@jonasbadstuebner
Copy link
Contributor

I am also using this plugin almost daily, so I would also be open to invest some time.
If I would have to become the core maintainer so the project does not "die", it would be fine by me. But if @sidlatau wants to take over that task, I would be happy about that and support him with opening and maybe testing PRs here and there.

@akinsho
Copy link
Collaborator Author

akinsho commented Aug 19, 2024

@sidlatau sounds great I think what I'll do is consider making an org and putting this plugin under the org and make you the lead maintainer but also so that if say you don't have time anymore in the future it's easier to designate other maintainers with sufficient powers to manage the project. I'll do that later on this week, thanks for stepping up, @jonasbadstuebner happy to add you also as a maintainer as well, will make @sidlatau the lead though as he has contributed for a very long time at this point

@jonasbadstuebner
Copy link
Contributor

Sounds great, I'm totally fine with @sidlatau being the lead - I only made one contribution so far and it was only last week.

@akinsho
Copy link
Collaborator Author

akinsho commented Sep 5, 2024

This is done now, I created an org called nvim-flutter and once you accept the invites @sidlatau and @jonasbadstuebner you should be made admins of it

@sidlatau
Copy link
Collaborator

sidlatau commented Sep 5, 2024

Thanks @akinsho, I accepted an invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests