NVDA focus highlight stuck on popup close button after closing the popup modal

[ankitonetrust]

Steps to reproduce:

1. Open a website link given : https://onetoso.com/__ankit__/sample_source/sample.html
2. Turn one NVDA and hit tab and access popup close button(x) to bottom of page
3. Press enter, it will close the banner and focus moved back to page body
   Note: Video link to reprocude issue: https://onetrust-my.sharepoint.com/:v:/p/ankit_kumar/EcsXxefwd9tKiv0c2nPPl4ABRzCZqMngEylmFmiyyG-jhQ?e=QSsQ4Z&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D

Actual behavior:

1. Upon closing the banner, the NVDA focus stays on screen

Expected behavior:

1. Focus should hide after closing the popup modal

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

NVDA version:

Windows version:

Windows 10

Name and version of other software in use when reproducing the issue:

Google chrome Version 128.0.6613.86

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

[SaschaCowley]

The issue is most likely because the code isn't resetting the focus properly after the modal is closed. Please confirm whether your javascript is restoring the focus to where it previously was before the dialog was opened.

[ankitonetrust]

upon checking the document.activeElement on browser console, it is shwoing correct focus i.e the focus back to the button which triggers the modal. But the dashes blue outline stays to the screen.

[SaschaCowley]

This seems to be working fine for me in Chrome and Firefox. It may simply be an issue with focus highlighting. @seanbudd could you please have a look?

[hwf1324]

This is actually a highlighter-related Issue.

Sometimes when the screen content changes, some objects are not updated, such as from focus mode to browse mode, when our operation no longer updates the focus object, this time will continue to highlight the previous focus object.

[ankitonetrust]

Can we expect any fix relate to this issue?

[seanbudd]

related to #15766