Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nv-morpheus/utilities
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a8fffb9fbacd8b43a8b8f4b08e516e7bca82c1b1
Choose a base ref
...
head repository: nv-morpheus/utilities
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3fde91526855f6f3d01b3e58f904647a97257f4b
Choose a head ref
  • 1 commit
  • 30 files changed
  • 1 contributor

Commits on Mar 15, 2023

  1. Improving the python CMake modules to speed up configure step (#17) 

    This fixes the python configure steps to not repeatedly call the same functions over and over.

Summary of changes:

- All python configure steps have been moved into a file instead of a function so we can take advantage of `include_guard()` to ensure it only runs once
   - The `python/register_api` script now defines functions that simply call `include()` on the necessary file
- Initialization of CPM is no longer done lazily. 
   - CPM sets variables that need to propagated to the parent scope. If you do this lazily inside of a function, you would have to call `set(VARIABLE PARENT_SCOPE)` in every location it could be lazily initialized
   - Instead, we assert that CPM has been initialized in all of the previous lazy invocations
- Several fixes to the python module creation code have been done to improve how they interact with CMake
   - Main improvement was to the `pip_gen_depfile.py` to work with more package names

Closes #14

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Devin Robison (https://github.com/drobison00)

URL: #17
    @mdemoret-nv
    mdemoret-nv authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    3fde915 View commit details
    Browse the repository at this point in the history
Loading