Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to README.md for clarity #91

Merged
3 commits merged into from
May 6, 2022
Merged

Updates to README.md for clarity #91

3 commits merged into from
May 6, 2022

Conversation

BartleyR
Copy link
Contributor

@BartleyR BartleyR commented May 6, 2022

Updated the README.md file as below.

  • Removed reference to getting started on NGC (was causing confusion)
  • Reworked language on getting started on GitHub
  • Minor formatting issues in the Kafka quick start section

@BartleyR BartleyR added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels May 6, 2022
@BartleyR BartleyR self-assigned this May 6, 2022
pdmack
pdmack requested changes May 6, 2022
View reviewed changes
Copy link
Contributor

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"container"

@BartleyR BartleyR requested a review from pdmack May 6, 2022 16:08
BartleyR
BartleyR commented May 6, 2022
View reviewed changes
Copy link
Contributor Author

@BartleyR BartleyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the container typo

pdmack
pdmack approved these changes May 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@BartleyR
Copy link
Contributor Author

BartleyR commented May 6, 2022

@gpucibot merge

@ghost ghost merged commit 6d497a4 into nv-morpheus:branch-22.06 May 6, 2022
@BartleyR BartleyR deleted the docs-updates-0506-br branch May 6, 2022 16:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmack pdmack pdmack approved these changes

@mdemoret-nv mdemoret-nv Awaiting requested review from mdemoret-nv

@raykallen raykallen Awaiting requested review from raykallen

Assignees

@BartleyR BartleyR

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BartleyR @pdmack