Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CLX parsers #894

Merged
merged 16 commits into from
May 5, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Apr 19, 2023

Description

  • Splunk Notable parser
  • Windows Event parser
  • URL parser
  • Zeek parser
  • IP parser
  • Unit tests

Tasks from Issue #508

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change feature request New feature or request labels Apr 19, 2023
@efajardo-nv efajardo-nv changed the title Migrate CLX parsers Migrate CLX log parsers Apr 19, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review April 24, 2023 14:37
@efajardo-nv efajardo-nv requested a review from a team as a code owner April 24, 2023 14:37
@efajardo-nv efajardo-nv changed the title Migrate CLX log parsers Migrate CLX parsers Apr 27, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My lone comment can be resolved if these tests came directly from CLX

tests/test_splunk_notable_parser.py Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@efajardo-nv Does this close out #508? Or are there more to do?

@efajardo-nv
Copy link
Contributor Author

Does this close out #508? Or are there more to do?

No, couple more tasks to close out #508.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 0f53830 into nv-morpheus:branch-23.07 May 5, 2023
@efajardo-nv efajardo-nv deleted the migrate-clx-parsers branch July 29, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants