Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 support #887

Merged
merged 22 commits into from
Apr 25, 2023
Merged

Python 3.10 support #887

merged 22 commits into from
Apr 25, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 14, 2023

Python 3.10 support

closes #881
closes #876

Todo:

@cwharris cwharris added breaking Breaking change feature request New feature or request labels Apr 14, 2023
@cwharris cwharris marked this pull request as ready for review April 15, 2023 00:23
@cwharris cwharris requested review from a team as code owners April 15, 2023 00:23
@mdemoret-nv
Copy link
Contributor

Final changes now that everything is working:

  1. Removal of the morpheus_utils.so library completely
    1. Only TableInfoData was compiled into this library and it only had a single function. This was moved and now only the header is shared between cudf_helpers and libmorpheus
  2. The library pyarrow was pinned to use cuda since it was defaulting to cpu for some reason.
  3. The layout of the morpheus._lib package has been updated to remove most of the cmake files.
    1. These files didnt do much and had longer copyright messages than implementations making it confusing
  4. The morpheus/_lib/src/python_modules have been moved to their respective directories.
    1. i.e. The common module moved from morpheus/_lib/src/python_modules/common.cpp to morpheus/_lib/common/module.cpp
    2. This leaves morpheus/_lib/src to contain only source files from libmorpheus
  5. The cudf_helpers CMake code has been brought into morpheus/_lib/CMakeLists.txt
    1. This is mainly due to this issue Stop assuming that pyx files are in the same directory as CMakeLists.txt scikit-build/scikit-build#871. Will need to file an issue with them.

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7d075f5 into nv-morpheus:branch-23.07 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Upgrade Morpheus to Python 3.10 [FEA]: Bump version of cupy
3 participants