Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devcontainer work for #702, #703 #717

Merged
merged 14 commits into from
Mar 8, 2023
Merged

Devcontainer work for #702, #703 #717

merged 14 commits into from
Mar 8, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Feb 17, 2023 •
edited
Loading

Closes #702
Closes #703

  • Adds gdb pretty printing support,
  • Moves .conda and .config folders to parent directory to share with mrc development.
  • Uses @trxcllnt 's new devcontainer base container which adds features such as mamba, automatic conda env mounting, etc.
  • introduces script to install pytest-kafka
  • Supports running GraphViz and SID visualizations from inside devcontainer accessable to host.

@cwharris cwharris requested a review from a team as a code owner February 17, 2023 18:29
@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Feb 17, 2023
@cwharris cwharris marked this pull request as draft February 17, 2023 20:39
@cwharris cwharris marked this pull request as ready for review February 24, 2023 16:36
@cwharris cwharris changed the title Devcontainer work for #702 Devcontainer work for #702, #703 Feb 24, 2023
mdemoret-nv
mdemoret-nv approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked well, compiled without issue, and extensions were all working. Once the conda name clash with multiple containers running at the same time is resolved, we can merge. Approving. Merge once comments are resolved.

.devcontainer/opt/morpheus/bin/post-attach-command.sh Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
@cwharris
Copy link
Contributor Author

cwharris commented Mar 7, 2023

@gpucibot merge

@rapids-bot
Copy link

rapids-bot bot commented Mar 7, 2023

@cwharris, the @gpucibot merge command has been replaced with /merge.

Please re-comment this PR with /merge and use this new command in the future.

@cwharris
Copy link
Contributor Author

cwharris commented Mar 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit e36419f into nv-morpheus:branch-23.03 Mar 8, 2023
@cwharris cwharris mentioned this pull request Mar 8, 2023
Merged
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this pull request Apr 28, 2023
@cwharris
Devcontainer Updates (#297)
4375b8a 
Changes similar to nv-morpheus/Morpheus#717

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt left review comments

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
3 participants
@cwharris @trxcllnt @mdemoret-nv