Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detecting index column when reading from CSV in C++ #714

Merged
merged 54 commits into from
Mar 20, 2023
Merged

Fix detecting index column when reading from CSV in C++ #714

merged 54 commits into from
Mar 20, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 16, 2023 •
edited
Loading

  • Fix logic in get_index_col_count in determining if the incoming DF has an index
  • C++ tests for deserializers
  • Expose the C++ deserializers to python

fixes #690

@dagardner-nv dagardner-nv requested a review from a team as a code owner February 16, 2023 17:59
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels Feb 16, 2023
mdemoret-nv
mdemoret-nv requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to discuss about these changes

morpheus/_lib/tests/test_deserializers.cpp Outdated Show resolved Hide resolved
morpheus/_lib/tests/test_deserializers.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/io/deserializers.cpp Show resolved Hide resolved
morpheus/_lib/src/io/deserializers.cpp Outdated Show resolved Hide resolved
morpheus/messages/message_meta.py Outdated Show resolved Hide resolved
morpheus/messages/message_meta.py Outdated Show resolved Hide resolved
morpheus/messages/message_meta.py Outdated Show resolved Hide resolved
morpheus/messages/message_meta.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Feb 24, 2023
@dagardner-nv dagardner-nv added 3 - Ready for Review and removed Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order labels Feb 27, 2023
mdemoret-nv
mdemoret-nv approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. The roundtrip tests will help keep things stable.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5bae77f into nv-morpheus:branch-23.03 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Deserializing a dataframe from C++ never detects an index
2 participants
@dagardner-nv @mdemoret-nv