Fix DFPTraining validation set option #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
approved these changes
Feb 16, 2023
mdemoret-nv
approved these changes
Feb 16, 2023
dagardner-nv
approved these changes
Feb 21, 2023
|
Created issue #733 to address my comment since we will need a bigger solution for testing examples. |
|
/merge |
jjacobelli
pushed a commit
to jjacobelli/Morpheus
that referenced
this pull request
Mar 7, 2023
- Fix `validation_size` validation. Allow for `validation_size=0.0` for no validation set. - Pass `run_validation` to dfencoder `fit()`. This option was recently added to `fit()` and is now required to enable use of a validation set and early stopping. Fixes nv-morpheus#707 Fixes nv-morpheus#708 Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - David Gardner (https://github.com/dagardner-nv) URL: nv-morpheus#709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validation_sizevalidation. Allow forvalidation_size=0.0for no validation set.run_validationto dfencoderfit(). This option was recently added tofit()and is now required to enable use of a validation set and early stopping.Fixes #707
Fixes #708