-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python bindings for TensorMemory #655
Merged
rapids-bot
merged 88 commits into
nv-morpheus:branch-23.03
from
dagardner-nv:david-constructors-604
Mar 7, 2023
Merged
Fix Python bindings for TensorMemory #655
rapids-bot
merged 88 commits into
nv-morpheus:branch-23.03
from
dagardner-nv:david-constructors-604
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
Something isn't working
non-breaking
Non-breaking change
2 - In Progress
labels
Jan 30, 2023
mdemoret-nv
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better. Still need to resolve the outstanding comments but those should be quick. Approved. Merge once all comments are resolved.
…ound to a property [no ci]
…ound to a property [no ci]
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Log a deprecation warning from the constructor for `ResponseMemoryProbs` & `MultiResponseMemoryProbs` * Replace usage of `ResponseMemoryProbs` with `ResponseMemory` * Replace usage of `MultiResponseProbsMessage` with `MultiResponseMessage` * `AddClassificationsStage` and `AddScoresStage` now accept an optional `output_name="probs"` constructor argument. * *breaking* Any custom stages which only return `MultiResponseMemoryProbs` from the `accepted_types` method will fail during pipeline build. * Includes changes in PR #655 fixes #697 Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorMemory
,InferenceMemory
&ResponseMemory
classes.tensors
attribute for memory classes with explicitget_tensors
andset_tensors
methods.MultiTensorMessage
class to Python allowing Python inheritance hierarchy to match that of C++, and consolidating some duplicated code.The reason for removing the attribute is that on the C++ side returning a Python representation of a tensor is rather costly and is always returned as a copy. We want to avoid the obvious bugs that can occur with anyone doing:
Which would have worked when C++ execution is disabled, and the old API is implying that it should work. Instead the API is changed to:
fixes #604