Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobuf to 3.20.2 #648

Merged
4 commits merged into from
Jan 30, 2023
Merged

Update protobuf to 3.20.2 #648

4 commits merged into from
Jan 30, 2023

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Jan 27, 2023

Fixes #647

@pdmack pdmack added bug Something isn't working dependencies Pull requests that update a dependency file non-breaking Non-breaking change improvement Improvement to existing functionality 3 - Ready for Review labels Jan 27, 2023
@pdmack pdmack requested a review from a team as a code owner January 27, 2023 22:14
@pdmack pdmack removed the bug Something isn't working label Jan 27, 2023
mdemoret-nv
mdemoret-nv approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up the duplicate requirement. LGTM

@pdmack
Copy link
Contributor Author

pdmack commented Jan 28, 2023

Actually @mdemoret-nv if we don't fix it in pip and conda the release container gets:

# conda list | grep protobuf
libprotobuf               3.20.2               h6239696_0    conda-forge
protobuf                  3.20.1                   pypi_0    pypi

@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit 291e102 into nv-morpheus:branch-23.01 Jan 30, 2023
@pdmack pdmack deleted the pdmack_protobuf-update branch April 4, 2023 15:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@mdemoret-nv mdemoret-nv

Labels
dependencies Pull requests that update a dependency file improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: protobuf CVE
2 participants
@pdmack @mdemoret-nv