Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Kafka & Triton deps are documented when used #598

Merged
17 commits merged into from
Jan 6, 2023
Merged

Ensure Kafka & Triton deps are documented when used #598

17 commits merged into from
Jan 6, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 6, 2023 •
edited
Loading

  • Replace from-kafka with from-file for first example in the Building a Pipeline doc
  • from-kafka introduced later as a more advanced example.
  • Link to the Quick Launch Kafka Cluster doc in Kafka example
  • Merge the Basic Usage Examples doc with the Building a Pipeline doc. These two docs were similar in nature, and the symlinks from the docs dir into the examples dir broke some links.
  • Ensure the .tmp dir exists, and add examples/data/dfp to .gitignore

fixes #591

@dagardner-nv dagardner-nv requested a review from a team as a code owner January 6, 2023 00:05
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels Jan 6, 2023
bsuryadevara
bsuryadevara requested changes Jan 6, 2023
View reviewed changes
docs/source/basics/building_a_pipeline.md Outdated Show resolved Hide resolved
docs/source/basics/building_a_pipeline.md Outdated Show resolved Hide resolved
docs/source/basics/building_a_pipeline.md Outdated Show resolved Hide resolved
docs/source/basics/building_a_pipeline.md Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 6, 2023 18:58
bsuryadevara
bsuryadevara approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@bsuryadevara bsuryadevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pdmack
pdmack approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions but LGTM
Very clear and concise

@dagardner-nv
Copy link
Contributor Author

/merge

1 similar comment
@dagardner-nv
Copy link
Contributor Author

/merge

@ghost ghost merged commit bb058c5 into nv-morpheus:branch-23.01 Jan 6, 2023
This was referenced Jan 17, 2023
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmack pdmack pdmack approved these changes

@bsuryadevara bsuryadevara bsuryadevara approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
23.01 Documentation Updates
Development

Successfully merging this pull request may close these issues.

[DOC]: Basic CLI usage doc assumes existence of a Kafka Broker
3 participants
@dagardner-nv @pdmack @bsuryadevara