Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stated explicitly regarding helm chart names #592

Merged

Conversation

bsuryadevara
Copy link
Contributor

  • Stated explicitly regarding helm chart names

Closes #564

@bsuryadevara bsuryadevara added non-breaking Non-breaking change doc Improvements or additions to documentation 2 - In Progress labels Jan 4, 2023
@bsuryadevara bsuryadevara self-assigned this Jan 4, 2023
@bsuryadevara bsuryadevara marked this pull request as ready for review January 4, 2023 18:46
@bsuryadevara bsuryadevara requested a review from a team as a code owner January 4, 2023 18:46
Copy link
Contributor

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
helm should be "Helm"

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bsuryadevara
Copy link
Contributor Author

nit helm should be "Helm"
done

nit helm should be "Helm"

Updated. thanks

@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit e5e3964 into nv-morpheus:branch-23.01 Jan 9, 2023
@bsuryadevara bsuryadevara deleted the 564-doc-helm-chart-reference-names branch May 5, 2023 17:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: Make it clear when referring to the name of a helm chart
4 participants