Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pluggy to docker build for CLI; fixes 357 #358

Merged
2 commits merged into from
Sep 15, 2022

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Sep 15, 2022

Fixes #357
Conda pulls it in by default via pytest but need to explicitly add for docker in requirements

@pdmack pdmack added bug Something isn't working 3 - Ready for Review labels Sep 15, 2022
@pdmack pdmack requested a review from a team as a code owner September 15, 2022 15:32
@pdmack pdmack added the breaking Breaking change label Sep 15, 2022
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner September 15, 2022 16:13
Copy link
Contributor Author

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged this pull request into nv-morpheus:branch-22.09 Sep 15, 2022
mdemoret-nv pushed a commit that referenced this pull request Sep 15, 2022
Fixes #357
Conda pulls it in by default via pytest but need to explicitly add for docker in requirements

Authors:
  - Pete MacKinnon (https://github.com/pdmack)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #358
@pdmack pdmack deleted the pdmack_pluggy-357 branch September 19, 2022 12:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Missing "pluggy" package for import
3 participants