Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant copy of the load_labels_file method #1901

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Removes morpheus.cli.utils.load_labels_file in favor of morpheus.utils.file_utils.load_labels_file since this method is of use outside of the CLI tools.
  • For backwards compatibility load_labels_file is imported into morpheus.cli.utils

Closes #1900

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 19, 2024
@dagardner-nv dagardner-nv self-assigned this Sep 19, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners September 19, 2024 20:45
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c24ca43 into nv-morpheus:branch-24.10 Sep 25, 2024
17 checks passed
@dagardner-nv dagardner-nv deleted the david-redundant-load_labels_file-1900 branch September 25, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: Remove redundant load_labels_file method
2 participants