Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of the C++ impl of write_df_to_file #1840

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix usage of the C++ impl of write_df_to_file #1840

merged 2 commits into from
Aug 14, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Fixes a bug when C++ mode is enabled, the file would be written twice.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 12, 2024
@dagardner-nv dagardner-nv self-assigned this Aug 12, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 12, 2024 21:18
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 13, 2024 21:05
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f33776e into nv-morpheus:branch-24.10 Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv