Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kafka offset checking test #1212

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Fix Kafka offset checking test #1212

merged 8 commits into from
Sep 22, 2023

Commits on Sep 21, 2023

  1. Whitespace change to trigger CI

    @dagardner-nv
    dagardner-nv committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    15a7365 View commit details
    Browse the repository at this point in the history

  2. Revert "Whitespace change to trigger CI" 

    This reverts commit 15a7365.
    @dagardner-nv
    dagardner-nv committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    85557dc View commit details
    Browse the repository at this point in the history

  3. Declare OffsetChecker as a MRC component so that it executes prior to… 

    … the source's yield returns.

Adjust the offset checker to pass if there is a new partition introduced.
    @dagardner-nv
    dagardner-nv committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    948f4ef View commit details
    Browse the repository at this point in the history

  4. Revert "Declare OffsetChecker as a MRC component so that it executes … 

    …prior to the source's yield returns."

This reverts commit 948f4ef.
    @dagardner-nv
    dagardner-nv committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b3d73ae View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Expose seek to beginning logic as a function, create kafka_consumer w… 

    …ith a group_id
    @dagardner-nv
    dagardner-nv committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    577bd5b View commit details
    Browse the repository at this point in the history

  2. Move the offset checking from a stage to the test body to be executed… 

    … after the pipeline completes. The reason is that the C++ impl commits the offsets after calling on_next, this also adds the ability to check async commits as well
    @dagardner-nv
    dagardner-nv committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3b5d9b9 View commit details
    Browse the repository at this point in the history

  3. Parametrize on async_commits

    @dagardner-nv
    dagardner-nv committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    56332b1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-23.11' into david-ci-kafka-errors

    @dagardner-nv
    dagardner-nv authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d38caea View commit details
    Browse the repository at this point in the history